[GitHub] [tvm] ekalda commented on a diff in pull request #12448: Add Arm DSP implementation of Depthwise Conv2D

[GitBox <gi...@apache.org>]

ekalda commented on code in PR #12448:
URL: https://github.com/apache/tvm/pull/12448#discussion_r960764383


##########
python/tvm/topi/arm_cpu/mprofile/dsp/micro_kernel/quad_channel_convolve.py:
##########
@@ -0,0 +1,180 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""This is a special intrinsic used for depthwise convolution using Cortex-M DSP instructions
+(v7e-m). It takes as inputs an int8 HWC data tensor and an int8 CHWc kernel. This intrinsic "lays"
+the kernel on top of the data tensors tarting from a given pointer, performs signed sixteen-bit

Review Comment:
   Nit:
   ```suggestion
   the kernel on top of the data tensors starting from a given pointer, performs signed sixteen-bit
   ```



##########
tests/python/relay/strategy/arm_cpu/test_depthwise_conv2d.py:
##########
@@ -147,5 +147,30 @@ class TestDepthwiseConv2d_NHWC_HWOI(BasicDepthwiseConv2dTests):
     schedule_name = tvm.testing.parameter("depthwise_conv2d_nhwc.generic")
 
 
+class TestDepthwiseConv2d_NHWC_HWOI_DSP(BasicDepthwiseConv2dTests):
+    """This test is for depthwise_conv2d_nhwc.generic schedule."""

Review Comment:
   Nit: update the docstring with the correct schedule name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org