You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/06 16:43:42 UTC

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

slinkydeveloper commented on a change in pull request #17350:
URL: https://github.com/apache/flink/pull/17350#discussion_r723486705



##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -331,7 +338,7 @@ private RowDataPartitionComputer partitionComputer() {
         return new FileSystemFormatFactory.ReaderContext() {
             @Override
             public TableSchema getSchema() {

Review comment:
       I don't think we should, because the `FileSystemFormatFactory` is deprecated and we need to prune it anyway. I was thinking to do that in a separate issue (there are only 2 implementations for that, avro and csv IIRC)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org