[jira] Commented: (TILES-87) BasicTilesContainer.calculateType is called even if an attribute does not need preprocessing

["Antonio Petrelli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/struts/browse/TILES-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40927 ] 

Antonio Petrelli commented on TILES-87:
---------------------------------------

The attribute type is no more set in the attribute, inside the calculateType method, therefore the performances are a little worse than stated in the description of the issue.
And, if the attribute is not a string, the attribute type is checked twice, the second time when calling "isDefinition" in the "render" (for attributes) method.

> BasicTilesContainer.calculateType is called even if an attribute does not need preprocessing
> --------------------------------------------------------------------------------------------
>
>                 Key: TILES-87
>                 URL: https://issues.apache.org/struts/browse/TILES-87
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core
>    Affects Versions: 2.0.0
>         Environment: N/A (it's a design issue)
>            Reporter: Antonio Petrelli
>            Priority: Minor
>             Fix For: 2.0.x
>
>
> The BasicTilesContainer.calculateType method is called for every attribute, even those that have been already preprocessed.
> Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.