You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/26 07:55:00 UTC
[jira] [Commented] (CB-13113) isVirtual is undefined on Browser
[ https://issues.apache.org/jira/browse/CB-13113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101295#comment-16101295 ]
ASF GitHub Bot commented on CB-13113:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/69
CB-13113 (browser) device.isVirtual is always false
### Platforms affected
Browser
### What does this PR do?
Introduces device.isVirtual to browser platform and makes it always equal `false`
### What testing has been done on this change?
an automated test run on browser platform
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-device CB-13113
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit a886200d3f9a56a4de21090effca050c94613a2b
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2017-07-26T07:49:05Z
CB-13113 (browser) device.isVirtual is always false
----
> isVirtual is undefined on Browser
> ---------------------------------
>
> Key: CB-13113
> URL: https://issues.apache.org/jira/browse/CB-13113
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-plugin-device
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
> Labels: found-by-ci, triaged
>
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-device/build/1.0.10/job/ipb89kpr9qndsj6j
> One of the tests fails on browser platform:
> {noformat}
> 1) cordova-plugin-device-tests.tests >> Device Information (window.device) should contain an isVirtual property that is a boolean
> - Expected undefined to be defined.
> - Expected 'undefined' to be 'boolean'.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org