You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/09/12 08:37:13 UTC
svn commit: r1881652 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
Author: tilman
Date: Sat Sep 12 08:37:13 2020
New Revision: 1881652
URL: http://svn.apache.org/viewvc?rev=1881652&view=rev
Log:
PDFBOX-4892: refactor
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java?rev=1881652&r1=1881651&r2=1881652&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java Sat Sep 12 08:37:13 2020
@@ -759,10 +759,6 @@ public final class PDAcroForm implements
*/
private boolean resolveNeedsTranslation(PDAppearanceStream appearanceStream)
{
- // a field without specific settings typically needs to be translated
- // to the correct position
- boolean needsTranslation = true;
-
PDResources resources = appearanceStream.getResources();
if (resources != null && resources.getXObjectNames().iterator().hasNext())
{
@@ -782,7 +778,7 @@ public final class PDAcroForm implements
float llY = bbox.getLowerLeftY();
if (Float.compare(llX, 0) != 0 && Float.compare(llY, 0) != 0)
{
- needsTranslation = false;
+ return false;
}
}
}
@@ -793,9 +789,10 @@ public final class PDAcroForm implements
LOG.debug("Couldn't resolve possible need for translation - ignoring, content might be misplaced", e);
}
}
- return needsTranslation;
}
-
+
+ // a field without specific settings typically needs to be translated
+ // to the correct position
return true;
}