You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/03 07:30:01 UTC
[GitHub] [spark] yaooqinn opened a new pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
yaooqinn opened a new pull request #34792:
URL: https://github.com/apache/spark/pull/34792
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Same as https://github.com/apache/spark/pull/18441, we parallelize FileInputFormat.listStatus for newAPIHadoopFile
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Spark can be slow when accessing external storage at driver side, improve perf by parallelizing
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
passing GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985281940
**[Test build #145888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145888/testReport)** for PR 34792 at commit [`a5bee79`](https://github.com/apache/spark/commit/a5bee79a635b2cc58ec3993391002c320cf54058).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985279708
cc @srowen @cloud-fan thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #34792:
URL: https://github.com/apache/spark/pull/34792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985316288
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50363/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761742739
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
Can you refer to the existing code if we have done this before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761789436
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
yes, as I mentioned https://github.com/apache/spark/pull/34792#discussion_r761702407, maybe some magic number 8/16 works better for all scenarios if we choose to hardcode it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761787184
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
Will this `availableProcessors` get the actual number of available CPU cores in container instances, VM instances and physical machine instances?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985364719
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50363/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985446088
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761744454
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
yes, https://github.com/apache/spark/blob/2d085c13b7f715dbff23dd1f81af45ff903d1a79/core/src/main/scala/org/apache/spark/rdd/WholeTextFileRDD.scala#L45-L46
https://github.com/apache/spark/blob/2d085c13b7f715dbff23dd1f81af45ff903d1a79/core/src/main/scala/org/apache/spark/rdd/BinaryFileRDD.scala#L42-L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985446088
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761702407
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
maybe we shall revamp the value for k8s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985364719
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50363/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985368377
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985281940
**[Test build #145888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145888/testReport)** for PR 34792 at commit [`a5bee79`](https://github.com/apache/spark/commit/a5bee79a635b2cc58ec3993391002c320cf54058).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985358460
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50363/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34792:
URL: https://github.com/apache/spark/pull/34792#discussion_r761788181
##########
File path: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala
##########
@@ -123,6 +123,10 @@ class NewHadoopRDD[K, V](
override def getPartitions: Array[Partition] = {
val inputFormat = inputFormatClass.getConstructor().newInstance()
+ // setMinPartitions below will call FileInputFormat.listStatus(), which can be quite slow when
+ // traversing a large number of directories and files. Parallelize it.
+ _conf.setIfUnset(FileInputFormat.LIST_STATUS_NUM_THREADS,
+ Runtime.getRuntime.availableProcessors().toString)
Review comment:
I'm not sure if using `Runtime.getRuntime.availableProcessors()` is really reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985420491
**[Test build #145888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145888/testReport)** for PR 34792 at commit [`a5bee79`](https://github.com/apache/spark/commit/a5bee79a635b2cc58ec3993391002c320cf54058).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #34792: [SPARK-37530][Core] Spark reads many paths very slow though newAPIHadoopFile
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #34792:
URL: https://github.com/apache/spark/pull/34792#issuecomment-985366951
GA pass, thanks merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org