You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Gal Palmery <Ga...@amdocs.com> on 2016/06/27 13:48:57 UTC
c++ client code fixes for contribution
Hi,
I have some code fixed in the c++ client code that I would like to contribute back to the community on behalf of Amdocs Development Limited.
I read about how to become a committer in geode here:
https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer
but since the c++ client is not in geode main dev branch currently, I was wondering what is the difference in this process, do I need to do something differently than described there?
Thanks,
Gal
This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp
RE: c++ client code fixes for contribution
Posted by Gal Palmery <Ga...@amdocs.com>.
Thanks!
-----Original Message-----
From: Dan Smith [mailto:dsmith@pivotal.io]
Sent: Tuesday, June 28, 2016 02:05
To: geode
Subject: Re: c++ client code fixes for contribution
Hi Dor, Gal,
Your contributions are welcome! As Anthony mentioned the preferred way to submit fixes to create a github pull request. A committer will review your request and either merge the changes or reply with comments. The link Anthony sent walks you through the process. You don't need any special access or permissions to create JIRA issues or submit pull requests, anyone can do it.
As far as changes to the native code go, I don't know what the state of that code is or how to build and test it. Hopefully someone more knowledgeable about that code can provide some guidance.
-Dan
On Mon, Jun 27, 2016 at 12:08 PM, Dor Ben Dov <do...@amdocs.com>
wrote:
> Anthony,
>
> I have checked with the relevant here on Amdocs, it seems that Amdocs
> already signed this paper couple years ago, guy named Avron Cohen. I
> can find the papers if needed.
>
> FYI
>
> Dor
>
> -----Original Message-----
> From: Anthony Baker [mailto:abaker@pivotal.io]
> Sent: יום ב 27 יוני 2016 19:47
> To: dev@geode.incubator.apache.org
> Subject: Re: c++ client code fixes for contribution
>
> Hi Gal,
>
> You don’t need to become a committer to make a code contribution.
> Here’s a guide to submitting a PR:
> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>
> Anthony
>
> > On Jun 27, 2016, at 6:48 AM, Gal Palmery <Ga...@amdocs.com> wrote:
> >
> > Hi,
> >
> > I have some code fixed in the c++ client code that I would like to
> contribute back to the community on behalf of Amdocs Development Limited.
> > I read about how to become a committer in geode here:
> > https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committ
> > er
> >
> > but since the c++ client is not in geode main dev branch currently,
> > I
> was wondering what is the difference in this process, do I need to do
> something differently than described there?
> >
> > Thanks,
> > Gal
> >
> > This message and the information contained herein is proprietary and
> > confidential and subject to the Amdocs policy statement, you may
> > review at http://www.amdocs.com/email_disclaimer.asp
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement, you may
> review at http://www.amdocs.com/email_disclaimer.asp
>
This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp
Re: c++ client code fixes for contribution
Posted by Dan Smith <ds...@pivotal.io>.
Hi Dor, Gal,
Your contributions are welcome! As Anthony mentioned the preferred way to
submit fixes to create a github pull request. A committer will review your
request and either merge the changes or reply with comments. The link
Anthony sent walks you through the process. You don't need any special
access or permissions to create JIRA issues or submit pull requests, anyone
can do it.
As far as changes to the native code go, I don't know what the state of
that code is or how to build and test it. Hopefully someone more
knowledgeable about that code can provide some guidance.
-Dan
On Mon, Jun 27, 2016 at 12:08 PM, Dor Ben Dov <do...@amdocs.com>
wrote:
> Anthony,
>
> I have checked with the relevant here on Amdocs, it seems that Amdocs
> already signed this paper couple years ago, guy named Avron Cohen. I can
> find the papers if needed.
>
> FYI
>
> Dor
>
> -----Original Message-----
> From: Anthony Baker [mailto:abaker@pivotal.io]
> Sent: יום ב 27 יוני 2016 19:47
> To: dev@geode.incubator.apache.org
> Subject: Re: c++ client code fixes for contribution
>
> Hi Gal,
>
> You don’t need to become a committer to make a code contribution. Here’s
> a guide to submitting a PR:
> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>
> Anthony
>
> > On Jun 27, 2016, at 6:48 AM, Gal Palmery <Ga...@amdocs.com> wrote:
> >
> > Hi,
> >
> > I have some code fixed in the c++ client code that I would like to
> contribute back to the community on behalf of Amdocs Development Limited.
> > I read about how to become a committer in geode here:
> > https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer
> >
> > but since the c++ client is not in geode main dev branch currently, I
> was wondering what is the difference in this process, do I need to do
> something differently than described there?
> >
> > Thanks,
> > Gal
> >
> > This message and the information contained herein is proprietary and
> > confidential and subject to the Amdocs policy statement, you may
> > review at http://www.amdocs.com/email_disclaimer.asp
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp
>
RE: c++ client code fixes for contribution
Posted by Dor Ben Dov <do...@amdocs.com>.
Anthony,
I have checked with the relevant here on Amdocs, it seems that Amdocs already signed this paper couple years ago, guy named Avron Cohen. I can find the papers if needed.
FYI
Dor
-----Original Message-----
From: Anthony Baker [mailto:abaker@pivotal.io]
Sent: יום ב 27 יוני 2016 19:47
To: dev@geode.incubator.apache.org
Subject: Re: c++ client code fixes for contribution
Hi Gal,
You don’t need to become a committer to make a code contribution. Here’s a guide to submitting a PR:
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Anthony
> On Jun 27, 2016, at 6:48 AM, Gal Palmery <Ga...@amdocs.com> wrote:
>
> Hi,
>
> I have some code fixed in the c++ client code that I would like to contribute back to the community on behalf of Amdocs Development Limited.
> I read about how to become a committer in geode here:
> https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer
>
> but since the c++ client is not in geode main dev branch currently, I was wondering what is the difference in this process, do I need to do something differently than described there?
>
> Thanks,
> Gal
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement, you may
> review at http://www.amdocs.com/email_disclaimer.asp
This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp
Re: c++ client code fixes for contribution
Posted by Anthony Baker <ab...@pivotal.io>.
Hi Gal,
You don’t need to become a committer to make a code contribution. Here’s a guide to submitting a PR:
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Anthony
> On Jun 27, 2016, at 6:48 AM, Gal Palmery <Ga...@amdocs.com> wrote:
>
> Hi,
>
> I have some code fixed in the c++ client code that I would like to contribute back to the community on behalf of Amdocs Development Limited.
> I read about how to become a committer in geode here:
> https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer
>
> but since the c++ client is not in geode main dev branch currently, I was wondering what is the difference in this process, do I need to do something differently than described there?
>
> Thanks,
> Gal
>
> This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp