You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2023/01/12 03:27:09 UTC
[GitHub] [shenyu] Inuyasha-Monster opened a new pull request, #4312: [ISSUE #4301] optimize message's builder generation.
Inuyasha-Monster opened a new pull request, #4312:
URL: https://github.com/apache/shenyu/pull/4312
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
close #4301
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Inuyasha-Monster commented on pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
Posted by GitBox <gi...@apache.org>.
Inuyasha-Monster commented on PR #4312:
URL: https://github.com/apache/shenyu/pull/4312#issuecomment-1383516699
OMG, I seem to have made a mistake. The message builder cannot be reused at all, because reuse may cause thread safety problems. A remote request corresponds to a new message builder is right... sorry about this pr...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Inuyasha-Monster commented on pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
Posted by GitBox <gi...@apache.org>.
Inuyasha-Monster commented on PR #4312:
URL: https://github.com/apache/shenyu/pull/4312#issuecomment-1383518062
However, the logic for judging as empty can be advanced to prevent null pointer exceptions of `merge` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Inuyasha-Monster commented on pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
Posted by GitBox <gi...@apache.org>.
Inuyasha-Monster commented on PR #4312:
URL: https://github.com/apache/shenyu/pull/4312#issuecomment-1383077507
by `builder.clear();` fix repeat use builder exception -->
com.google.protobuf.InvalidProtocolBufferException: Field echo.EchoRequest.message has already been set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Inuyasha-Monster closed pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
Posted by GitBox <gi...@apache.org>.
Inuyasha-Monster closed pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
URL: https://github.com/apache/shenyu/pull/4312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4312: [ISSUE #4301] optimize grpc method parameter message's builder generation.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4312:
URL: https://github.com/apache/shenyu/pull/4312#issuecomment-1382053631
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4312](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6ce2ca) into [master](https://codecov.io/gh/apache/shenyu/commit/f977511726ce18cfac6f228a138f3168011ea085?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f977511) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4312 +/- ##
============================================
- Coverage 68.01% 67.99% -0.03%
+ Complexity 7453 7446 -7
============================================
Files 1015 1015
Lines 28733 28733
Branches 2574 2574
============================================
- Hits 19543 19536 -7
- Misses 7661 7671 +10
+ Partials 1529 1526 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/shenyu/common/timer/HierarchicalWheelTimer.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi90aW1lci9IaWVyYXJjaGljYWxXaGVlbFRpbWVyLmphdmE=) | `68.00% <0.00%> (-14.00%)` | :arrow_down: |
| [...va/org/apache/shenyu/common/timer/TimingWheel.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi90aW1lci9UaW1pbmdXaGVlbC5qYXZh) | `73.80% <0.00%> (-9.53%)` | :arrow_down: |
| [.../org/apache/shenyu/common/timer/TimerTaskList.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi90aW1lci9UaW1lclRhc2tMaXN0LmphdmE=) | `74.72% <0.00%> (-7.70%)` | :arrow_down: |
| [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `55.33% <0.00%> (-0.67%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `89.79% <0.00%> (+8.16%)` | :arrow_up: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/shenyu/pull/4312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `82.75% <0.00%> (+13.79%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org