[jira] Commented: (MYFACES-2492) Update and create Mock classes in myfaces-test20

["Jakob Korherr (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831968#action_12831968 ] 

Jakob Korherr commented on MYFACES-2492:
----------------------------------------

So, I finally made it through your patch and I ran all related tests for the test module (I also ran all myfaces api, impl and shared tests with your new mock classes locally).

There were just some few things I had to change/add:

- the document root in MockResourceTestCase had to be changed in order to run the test successfully
- the license information was missing in testfile.js
- You used your own _messages instance variable in MockFacesContext20 for the getMessageList() methods, but you forgot that the messages Map is internally used in MockFacesContext for some more methods (I noticed that because some tests failed when I tried to build myfaces-api). So I made the messages instance variable in MockFacesContext protected, removed your addMessage method and changed the getMessageList() methods accordingly.

> Update and create Mock classes in myfaces-test20
> ------------------------------------------------
>
>                 Key: MYFACES-2492
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2492
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>            Reporter: Ingo Hofmann
>         Attachments: extended_mock_classes1.patch
>
>
> Update existing Mock classes in myfaces-test20 (MyFaces test framework) to JSF 2.0 API and write Mock classes for new 2.0 classes from core project.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.