You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 18:19:01 UTC
[GitHub] [arrow] nevi-me opened a new pull request #9094: ARROW-11126: [Rust] Document and test ARROW-10656
nevi-me opened a new pull request #9094:
URL: https://github.com/apache/arrow/pull/9094
I hadn't pushed these 2 commits to the ARROW-10656 branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9094: ARROW-11126: [Rust] Document and test ARROW-10656
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9094:
URL: https://github.com/apache/arrow/pull/9094#issuecomment-754134007
https://issues.apache.org/jira/browse/ARROW-11126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9094: ARROW-11126: [Rust] Document and test ARROW-10656
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9094:
URL: https://github.com/apache/arrow/pull/9094#discussion_r551527136
##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -80,6 +80,10 @@ impl RecordBatch {
Ok(RecordBatch { schema, columns })
}
+ /// Creates a [RecordBatch` from a schema and columns, with additional options,
Review comment:
```suggestion
/// Creates a [`RecordBatch`] from a schema and columns, with additional options,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9094: ARROW-11126: [Rust] Document and test ARROW-10656
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9094:
URL: https://github.com/apache/arrow/pull/9094#discussion_r551536755
##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -80,6 +80,10 @@ impl RecordBatch {
Ok(RecordBatch { schema, columns })
}
+ /// Creates a [RecordBatch` from a schema and columns, with additional options,
Review comment:
Thanks, I meant for it to be `RecordBatch`, as the link has little value. I think I removed the wrong character while changing it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9094: ARROW-11126: [Rust] Document and test ARROW-10656
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9094:
URL: https://github.com/apache/arrow/pull/9094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org