You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Mladen Turk (JIRA)" <ji...@apache.org> on 2010/05/20 19:37:16 UTC
[jira] Created: (TS-364) Remove LLONG from configure system
Remove LLONG from configure system
----------------------------------
Key: TS-364
URL: https://issues.apache.org/jira/browse/TS-364
Project: Traffic Server
Issue Type: Task
Components: Cleanup
Reporter: Mladen Turk
Assignee: Mladen Turk
Priority: Minor
Fix For: 2.1.0
Seems there was a general consensus to nuke the LLNOG from the config options
and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-364) Remove LLONG from configure system
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-364:
-----------------------------
Attachment: TS-364.diff
Proposed changes. This eliminates all LLONG "features" of librecords, and also fixes a few places where we did not support 64-bit value interpretation of the "integer". Note that there are still APIs for those RECs that wants to be 32-bit (I have not touched those).
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.2
>
> Attachments: TS-364.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-364) Remove LLONG from configure system
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869721#action_12869721 ]
Leif Hedstrom commented on TS-364:
----------------------------------
I took a quick look, and I see what happened before. There are several areas in the code for Rec Integer configs that we downcast to an int32. For example:
librecords/I_RecCore.h: _var = (int)REC_ConfigReadInteger(_config_var_name); \
librecords/I_RecCore.h: _var = (int32)REC_ConfigReadInteger(_config_var_name); \
librecords/I_RecCore.h: _var = (int32)REC_ConfigReadInteger(_config_var_name); \
There are several other places with the same problem, so part of this "cleanup" will also require to make all "RecInt" accessors and marshalling utilities to use int64 as well. My recommendation would be to fix that first, and commit (for testing), before we remove and "rename" the two configs that use LLONG.
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Priority: Minor
> Fix For: 2.1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-364) Remove LLONG from configure system
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-364.
------------------------------
Resolution: Fixed
Reviewed by George, committed
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.2
>
> Attachments: TS-364.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-364) Remove LLONG from configure system
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk updated TS-364:
---------------------------
Fix Version/s: 2.1.2
(was: 2.1.1)
Target this for 2.1.2 since some work has been already done as part of 64-bit patches
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Priority: Minor
> Fix For: 2.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-364) Remove LLONG from configure system
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-364:
--------------------------------
Assignee: Leif Hedstrom (was: Mladen Turk)
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-364) Remove LLONG from configure system
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869978#action_12869978 ]
Mladen Turk commented on TS-364:
--------------------------------
The solution here would be to actually make REC_ConfigReadInterger to cast to int32 (well actually convert to int32 using ink_atoi from string)
What I was saying yesterday was actually that.
Let all config values be INT (int64)
REC_ConfigReadInteger (Rename to REC_ConfigReadInt32) returns int32
REC_ConfigReadLLong (Rename to REC_ConfigReadInt64) returns int64
So, any code that needs to read a config value would decide what to read actually.
The INT parser itself would then be able to return MAX_INT or MIN_INT on overflow or
even throw an exception.
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Priority: Minor
> Fix For: 2.1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-364) Remove LLONG from configure system
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878830#action_12878830 ]
Leif Hedstrom commented on TS-364:
----------------------------------
Taking this bug, since it's my fault :) Removing the LLONG crud, and fixing the areas where the RecInt is not properly 64-bit "safe".
> Remove LLONG from configure system
> ----------------------------------
>
> Key: TS-364
> URL: https://issues.apache.org/jira/browse/TS-364
> Project: Traffic Server
> Issue Type: Task
> Components: Cleanup
> Reporter: Mladen Turk
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Seems there was a general consensus to nuke the LLNOG from the config options
> and both unify and simplify the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.