You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/06 00:23:30 UTC
[GitHub] [superset] Damans227 opened a new pull request #17653: chore: migrate AsyncSelect component from jsx to tsx
Damans227 opened a new pull request #17653:
URL: https://github.com/apache/superset/pull/17653
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
PR for migrating `AsyncSelect` react component from JSX to TSX
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #10004
- [x] Enhancement (new features, refinement)
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Damans227 commented on a change in pull request #17653: chore: migrate AsyncSelect component from jsx to tsx
Posted by GitBox <gi...@apache.org>.
Damans227 commented on a change in pull request #17653:
URL: https://github.com/apache/superset/pull/17653#discussion_r762642815
##########
File path: superset-frontend/src/components/AsyncSelect/index.jsx
##########
@@ -29,6 +29,7 @@ const propTypes = {
mutator: PropTypes.func.isRequired,
onAsyncError: PropTypes.func,
value: PropTypes.oneOfType([
+ PropTypes.string,
Review comment:
Adding `string` as one of the types for the `value` prop to fix the following error in the `QuerySearch` component:
```
Error: src/SqlLab/components/QuerySearch/index.tsx(193,13): error TS2322: Type 'string' is not assignable to type 'number | (number | null)[] | null | undefined'.
Error: src/SqlLab/components/QuerySearch/index.tsx(202,13): error TS2322: Type 'string' is not assignable to type 'number | (number | null)[] | null | undefined'.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Damans227 commented on pull request #17653: chore: migrate AsyncSelect component from jsx to tsx
Posted by GitBox <gi...@apache.org>.
Damans227 commented on pull request #17653:
URL: https://github.com/apache/superset/pull/17653#issuecomment-986473187
@etr2460 Ptal, and share your feedback. looks like some unit tests are still failing. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org