[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2854: [GOBBLIN-1009] Create load balancer for Gobblin Service

[GitBox <gi...@apache.org>]

zxcware commented on a change in pull request #2854: [GOBBLIN-1009] Create load balancer for Gobblin Service
URL: https://github.com/apache/incubator-gobblin/pull/2854#discussion_r360614255
 
 

 ##########
 File path: gobblin-service-loadbalancer/src/main/java/org/apache/gobblin/service/loadbalancer/GobblinServiceLoadBalancer.java
 ##########
 @@ -0,0 +1,57 @@
+package org.apache.gobblin.service.loadbalancer;
+
+import com.google.common.base.Optional;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import org.apache.gobblin.runtime.app.ApplicationException;
+import org.apache.gobblin.runtime.app.ApplicationLauncher;
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.servlet.ServletContextHandler;
+import org.eclipse.jetty.servlet.ServletHolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class GobblinServiceLoadBalancer implements ApplicationLauncher {
+  private Server server;
 
 Review comment:
   Try if we can merge Load Balancing into the `nginx` server container. We might need create a load balancing image on top of an nginx image.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services