You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 01:27:30 UTC

[GitHub] [shardingsphere] rimal opened a new issue, #2826: Ability to define behaviour when sharding column is not present in the SQL

rimal opened a new issue, #2826:
URL: https://github.com/apache/shardingsphere/issues/2826

   ## Feature Request
   ### Is your feature request related to a problem?
   https://github.com/apache/incubator-shardingsphere/issues/2815
   
   ### Describe the feature you would like.
   There needs to be a way to define what to be done (which target names to be chosen) when sharding column is not in the SQL. Currently, as per `StandardRoutingEngine`, all available target names are returned. 
   
   As a suggestion, we can also think of 
   
   - moving this logic to the sharding algorithm itself. That means, let the sharding algorithm decide which target names to select in case there is no sharding column in the SQL 
   
   - and may be have a default behaviour, in case the sharding algorithm also does not return any target name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] vikiuvb commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

Posted by GitBox <gi...@apache.org>.
vikiuvb commented on issue #2826:
URL: https://github.com/apache/shardingsphere/issues/2826#issuecomment-1367776946

   @strongduanmu I'm working on this. Please assign it to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu closed issue #2826: Ability to define behaviour when sharding column is not present in the SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #2826: Ability to define behaviour when sharding column is not present in the SQL
URL: https://github.com/apache/shardingsphere/issues/2826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #2826:
URL: https://github.com/apache/shardingsphere/issues/2826#issuecomment-1368225085

   @vikiuvb Assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #2826: Ability to define behaviour when sharding column is not present in the SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #2826:
URL: https://github.com/apache/shardingsphere/issues/2826#issuecomment-1369338715

   Fixed by #22857.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org