[GitHub] [arrow] alamb commented on pull request #8654: ARROW-10572: [Rust][Datafusion] Use aHash instead of FnvHashMap

[GitBox <gi...@apache.org>]

alamb commented on pull request #8654:
URL: https://github.com/apache/arrow/pull/8654#issuecomment-726760544


   There appears to be a diff int he CI tests:
   https://github.com/apache/arrow/pull/8654/checks?check_run_id=1392391221
   
   ```
   
   ---- execution::context::tests::count_distinct_integers_aggregated_single_partition stdout ----
   thread 'execution::context::tests::count_distinct_integers_aggregated_single_partition' panicked at 'assertion failed: `(left == right)`
     left: `["a,3,2,2,2,2,2,2,2,2", "b,1,1,1,1,1,1,1,1,1", "c,3,2,2,2,2,2,2,2,2"]`,
    right: `["a,3,2,2,2,2,2,2,2,2", "c,3,2,2,2,2,2,2,2,2", "b,1,1,1,1,1,1,1,1,1"]`', datafusion/src/execution/context.rs:1077:9
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ---- execution::context::tests::count_distinct_integers_aggregated_multiple_partitions stdout ----
   thread 'execution::context::tests::count_distinct_integers_aggregated_multiple_partitions' panicked at 'assertion failed: `(left == right)`
     left: `["b,5,4,4,4,4,4,4,4,4", "a,5,3,3,3,3,3,3,3,3", "c,1,1,1,1,1,1,1,1,1"]`,
    right: `["a,5,3,3,3,3,3,3,3,3", "c,1,1,1,1,1,1,1,1,1", "b,5,4,4,4,4,4,4,4,4"]`', datafusion/src/execution/context.rs:1105:9
   ```
   
   Which is likely due to the change in order of the output (the values appear to be the same) which is not surprising given a change in the hash algorithm -- perhaps the test just needs to be updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org