You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by jschmerge <gi...@git.apache.org> on 2017/04/21 15:27:12 UTC
[GitHub] incubator-trafficcontrol pull request #497: Allow specification of the 'id' ...
GitHub user jschmerge opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/497
Allow specification of the 'id' parameter for storage.config
This patch adds three new parameters to control/configure the seed
strings for the consistent hash used for cachekey->drive mapping in
ATS... This allows an arbitrary string to be assigned as the key for
drives instead of relying on the OS's device node name as the seed for
the hash. The three parameters added are:
* Drive_Hash_Id
* RAM_Drive_Hash_Id
* SSD_Drive_Hash_Id
And they specify the id keys for spinning, ram, and ssd devices.
If this parameter is missing from the TO config for a server, the
generated file ommits any specification of the id parameter (preserving
the previous file generation behavior).
Also note that the csv id strings for these three new parameters should
order their entries to match the order of the Drive_Letters parameter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jschmerge/incubator-trafficcontrol master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit 56c667ccb0338ed8ab34faf0db802d735b509022
Author: John Schmerge <jo...@cable.comcast.com>
Date: 2017-04-14T22:35:37Z
Allow specification of the 'id' parameter for storage.config
This patch adds three new parameters to control/configure the seed
strings for the consistent hash used for cachekey->drive mapping in
ATS... This allows an arbitrary string to be assigned as the key for
drives instead of relying on the OS's device node name as the seed for
the hash. The three parameters added are:
* Drive_Hash_Id
* RAM_Drive_Hash_Id
* SSD_Drive_Hash_Id
And they specify the id keys for spinning, ram, and ssd devices.
If this parameter is missing from the TO config for a server, the
generated file ommits any specification of the id parameter (preserving
the previous file generation behavior).
Also note that the csv id strings for these three new parameters should
order their entries to match the order of the Drive_Letters parameter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/27/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: Allow specification of the 'id' paramet...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
I'm seeing a few issues here, like lack of declaration for @tmp_list, and trying to use @postfix in a different sub than where it was declared without passing it. I'm not sure what ($$) is either but that could be a lack of knowledge on my part - I just know it refuses to run with that in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: Allow specification of the 'id' paramet...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
@jschmerge - can you create a jira ticket for this? https://issues.apache.org/jira/browse/TC
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by oren-shemesh <gi...@git.apache.org>.
Github user oren-shemesh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
Indeed, an entry in the documentation explaining the purpose and usage of these parameters would be in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
What values would one typically set for the *_Hash_Id? Does it need to correspond to a property of the disks?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by jschmerge <gi...@git.apache.org>.
Github user jschmerge commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
The parameter is actually rather nicely documented with examples in the ATS documentation: https://docs.trafficserver.apache.org/en/latest/admin-guide/files/storage.config.en.html#linux-example
This patch just exposes the configuration item as a knob in traffic-ops.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: Allow specification of the 'id' paramet...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
Tested with the changes. Works as designed. Please merge with PR 527 for the API to match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by limited <gi...@git.apache.org>.
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
I understand the ATS storage.config parameter, but how is this ID configured/generated in Traffic Ops? Is there a per-disk ID parameter (i.e. if i have 72 disks there are now 72 new parameters)?
I looked at the referenced PR but it didnt seem to contain API changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...
Posted by jschmerge <gi...@git.apache.org>.
Github user jschmerge commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/497
I thought i had left a comment regarding this patch a few weeks back answering the question @limited posed...
I'm going to focus on just the Drive_Letters and Drive_Hash_Id params, the RAM_* and SSD_* work the same way.
The Drive_Hash_Id param takes a CSV string for *_all_* the drives, and the order is expected to match the order in the Drive_Letters CSV string. Provisions have been taken to allow for omitting a hash id for a drive, in that if:
Drive_Letters = "a,b,c,d,e"
and
Drive_Hash_Id = ",,foo,,bar"
You'll end up with a storage.config that contains:
`/dev/sda volume=1
/dev/sdb volume=1
/dev/sdc volume=1 id=foo
/dev/sdd volume=1
/dev/sde volume=1 id=bar`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---