You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vladislav Pyatkov (Jira)" <ji...@apache.org> on 2023/03/14 13:09:00 UTC

[jira] [Commented] (IGNITE-18997) Remove redundant future transformations from PartitionReplicaListener

    [ https://issues.apache.org/jira/browse/IGNITE-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700156#comment-17700156 ] 

Vladislav Pyatkov commented on IGNITE-18997:
--------------------------------------------

LGTM

Merged 405cf5116e5e49f0e07528f3c6fe17e29a19e3b9

Thank you for contribution.

> Remove redundant future transformations from PartitionReplicaListener
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-18997
>                 URL: https://issues.apache.org/jira/browse/IGNITE-18997
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Aleksandr Polovtcev
>            Assignee: Aleksandr Polovtcev
>            Priority: Trivial
>              Labels: ignite-3
>             Fix For: 3.0.0-beta2
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> PartitionReplicaListener has a following pattern in its code:
> {code:java}
> if (request instanceof ReplicaSafeTimeSyncRequest) {
>      return processReplicaSafeTimeSyncRequest((ReplicaSafeTimeSyncRequest) request)
>          .thenApply(Function.identity());
> }
> {code}
> This {{thenApply(Function.identity())}} is only needed for code being able to compile. This makes little sense, as we can simply use generic wildcards and remove these transfomations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)