You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/02 02:05:54 UTC
Review Request 58905: Changed naming of Docker containers to the
pre-0.23 scheme.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
The choice of naming scheme is cosmetic. All versions of the Docker
containerizer will consider containers starting with "mesos-"
as containers started by Mesos. The Docker containerizer does not
consider the `SlaveID` at all when recovering.
Diffs
-----
src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3
src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7
Diff: https://reviews.apache.org/r/58905/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 58905: Changed naming of Docker containers to the
pre-0.23 scheme.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/#review174641
-----------------------------------------------------------
src/slave/containerizer/docker.hpp
Line 318 (original), 319 (patched)
<https://reviews.apache.org/r/58905/#comment247845>
Have you considered the case where we can call 'usage' or 'update' after upgrade. Will the new code be able to handle old containers given the naming scheme has been changed?
- Jie Yu
On May 2, 2017, 2:05 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58905/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 2:05 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The choice of naming scheme is cosmetic. All versions of the Docker
> containerizer will consider containers starting with "mesos-"
> as containers started by Mesos. The Docker containerizer does not
> consider the `SlaveID` at all when recovering.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3
> src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7
>
>
> Diff: https://reviews.apache.org/r/58905/diff/1/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 58905: Changed naming of Docker containers to the
pre-0.23 scheme.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/#review175735
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 19, 2017, 10:14 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58905/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 10:14 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The choice of naming scheme is cosmetic. All versions of the Docker
> containerizer will consider containers starting with "mesos-"
> as containers started by Mesos. The Docker containerizer does not
> consider the `SlaveID` at all when recovering.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3
> src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7
>
>
> Diff: https://reviews.apache.org/r/58905/diff/2/
>
>
> Testing
> -------
>
> See last patch in chain.
>
> TODO: Add a backwards compatibility test .
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 58905: Changed naming of Docker containers to the
pre-0.23 scheme.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/
-----------------------------------------------------------
(Updated May 24, 2017, 3:34 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Deal with a prefix that appears in some versions of the output of `docker inspect`. This was causing `DockerContainerizerTest.ROOT_DOCKER_RecoverPersistentVolumes` to fail with this change.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
The choice of naming scheme is cosmetic. All versions of the Docker
containerizer will consider containers starting with "mesos-"
as containers started by Mesos. The Docker containerizer does not
consider the `SlaveID` at all when recovering.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3
src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7
Diff: https://reviews.apache.org/r/58905/diff/3/
Changes: https://reviews.apache.org/r/58905/diff/2-3/
Testing
-------
See last patch in chain.
TODO: Add a backwards compatibility test .
Thanks,
Joseph Wu
Re: Review Request 58905: Changed naming of Docker containers to the
pre-0.23 scheme.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58905/
-----------------------------------------------------------
(Updated May 19, 2017, 3:14 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Change recovery path to save the name of the container for use in later calls.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
The choice of naming scheme is cosmetic. All versions of the Docker
containerizer will consider containers starting with "mesos-"
as containers started by Mesos. The Docker containerizer does not
consider the `SlaveID` at all when recovering.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3
src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7
Diff: https://reviews.apache.org/r/58905/diff/2/
Changes: https://reviews.apache.org/r/58905/diff/1-2/
Testing (updated)
-------
See last patch in chain.
TODO: Add a backwards compatibility test .
Thanks,
Joseph Wu