You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2018/12/31 17:42:00 UTC

[jira] [Commented] (THRIFT-4702) Improve AutoExpandingBuffer

    [ https://issues.apache.org/jira/browse/THRIFT-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731392#comment-16731392 ] 

James E. King III commented on THRIFT-4702:
-------------------------------------------

This class could be used by third party transport implementations since it isn't internal / private already.

> Improve AutoExpandingBuffer
> ---------------------------
>
>                 Key: THRIFT-4702
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4702
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.12.0
>            Reporter: BELUGA BEHR
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The class has a concept of a "growth factor" which is a float value.  However, the growth value is hard-coded at 150%.  Instead, remove this configurable value, that isn't externally configurable, and instead use bit shifting to achieve a 150% increase instead of a a float value.
> Decrease the scope of this class since it is an internal utility and should not be directly consumed by outside code.
> Other miscellaneous cleanup and simplification.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)