You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2023/06/01 21:56:22 UTC
[GitHub] [arrow] amoeba opened a new pull request, #35880: MINOR: [Documentation][Python] Minor tweaks to docs around IPC messages
amoeba opened a new pull request, #35880:
URL: https://github.com/apache/arrow/pull/35880
### Rationale for this change
@jorisvandenbossche pointed out that the docstring for RecordBatch.serialize might not be clear enough and that users may be surprised to find out a Schema isn't included. This PR makes that clearer and improves up related documentation.
### Are these changes tested?
Yes. I built the docs and verified the rendering was correct and I ran the changed example locally. I didn't --doctest-cython it because it looks like that hasn't been set up for this module.
### Are there any user-facing changes?
No, these are just docs improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF merged pull request #35880: MINOR: [Documentation][Python] Minor tweaks to docs around IPC messages
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #35880:
URL: https://github.com/apache/arrow/pull/35880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #35880: MINOR: [Documentation][Python] Minor tweaks to docs around IPC messages
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #35880:
URL: https://github.com/apache/arrow/pull/35880#discussion_r1217598941
##########
python/pyarrow/table.pxi:
##########
@@ -2292,8 +2297,17 @@ cdef class RecordBatch(_Tabular):
>>> animals = pa.array(["Flamingo", "Parrot", "Dog", "Horse", "Brittle stars", "Centipede"])
>>> batch = pa.RecordBatch.from_arrays([n_legs, animals],
... names=["n_legs", "animals"])
- >>> batch.serialize()
+ >>> buf = batch.serialize()
+ >>> buf
<pyarrow.Buffer address=0x... size=... is_cpu=True is_mutable=True>
+ >>> # Reconstruct RecordBatch from IPC message Buffer and original Schema
Review Comment:
```suggestion
Reconstruct RecordBatch from IPC message Buffer and original Schema
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35880: MINOR: [Documentation][Python] Minor tweaks to docs around IPC messages
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35880:
URL: https://github.com/apache/arrow/pull/35880#issuecomment-1578055338
Benchmark runs are scheduled for baseline = 87d082477762fa9b720f5772c5331bd629ed90ba and contender = e2ae492b63245a8bc6330b10785777ab04659798. e2ae492b63245a8bc6330b10785777ab04659798 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0b5a207d4c1a4efcbbba25bcf5a10079...1b1cb8b1fa3540fb86acce5d7116e8c5/)
[Failed :arrow_down:0.42% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8bced070c2254025bb285fc8b792c598...af88293698f141488ed7f6629ccdf0a5/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/059a570021bf4fe7afbaff0fb83818e2...761ef5266fa348a8890278d54e013022/)
[Failed :arrow_down:0.42% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b02bad2427124ade9cebe813bcc05abd...dc2447ce9a5341c6a99dfb1c4f0d3549/)
Buildkite builds:
[Failed] [`e2ae492b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2981)
[Failed] [`e2ae492b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3017)
[Failed] [`e2ae492b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2982)
[Failed] [`e2ae492b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3007)
[Failed] [`87d08247` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2980)
[Failed] [`87d08247` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3016)
[Failed] [`87d08247` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2981)
[Failed] [`87d08247` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3006)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amoeba commented on pull request #35880: MINOR: [Documentation][Python] Minor tweaks to docs around IPC messages
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #35880:
URL: https://github.com/apache/arrow/pull/35880#issuecomment-1577021253
Good to know, thanks @AlenkaF. I accepted your suggestion and this should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org