You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2019/10/16 12:49:10 UTC
Review Request 71623: ATLAS-3472 Port jsp's to Servlet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3472
https://issues.apache.org/jira/browse/ATLAS-3472
Repository: atlas
Description
-------
This patch uses Servlets instead of JSP files to render login and error page.
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java PRE-CREATION
webapp/src/main/resources/spring-security.xml 1295244
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
webapp/src/main/webapp/error.html.template PRE-CREATION
webapp/src/main/webapp/error.jsp 29ef640
webapp/src/main/webapp/login.html.template PRE-CREATION
webapp/src/main/webapp/login.jsp 70ec06d
Diff: https://reviews.apache.org/r/71623/diff/1/
Testing
-------
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
Thanks,
Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218233
-----------------------------------------------------------
Please mention:
- Type of testing performed.
- Auth scenarios verified.
- Ashutosh Mestry
On Oct. 16, 2019, 12:49 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2019, 12:49 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218291
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java
Lines 33 (patched)
<https://reviews.apache.org/r/71623/#comment305959>
Consider moving these constants to AtlasLoginServlet and AtlasErrorServlet - as they are used only in these classes.
- Madhan Neethiraj
On Oct. 18, 2019, 10:31 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2019, 10:31 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/3/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
> Tested in browser with simple mode.
> Tested in browser with Knox proxy on kerberos mode.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218300
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 19, 2019, 3:10 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2019, 3:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/4/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
> Tested in browser with simple mode.
> Tested in browser with Knox proxy on kerberos mode.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/
-----------------------------------------------------------
(Updated Oct. 19, 2019, 3:10 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed review comments. Moved constants to respective classes.
Bugs: ATLAS-3472
https://issues.apache.org/jira/browse/ATLAS-3472
Repository: atlas
Description
-------
This patch uses Servlets instead of JSP files to render login and error page.
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION
webapp/src/main/resources/spring-security.xml 1295244
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
webapp/src/main/webapp/error.html.template PRE-CREATION
webapp/src/main/webapp/error.jsp 29ef640
webapp/src/main/webapp/login.html.template PRE-CREATION
webapp/src/main/webapp/login.jsp 70ec06d
Diff: https://reviews.apache.org/r/71623/diff/4/
Changes: https://reviews.apache.org/r/71623/diff/3-4/
Testing
-------
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
Tested in browser with simple mode.
Tested in browser with Knox proxy on kerberos mode.
Thanks,
Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218290
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Oct. 18, 2019, 10:31 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2019, 10:31 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/3/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
> Tested in browser with simple mode.
> Tested in browser with Knox proxy on kerberos mode.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/
-----------------------------------------------------------
(Updated Oct. 18, 2019, 10:31 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Handled review comments, Added Base class "AtlasHTTPServlet" to incorporate changes without using "if" clause.
Bugs: ATLAS-3472
https://issues.apache.org/jira/browse/ATLAS-3472
Repository: atlas
Description
-------
This patch uses Servlets instead of JSP files to render login and error page.
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION
webapp/src/main/resources/spring-security.xml 1295244
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
webapp/src/main/webapp/error.html.template PRE-CREATION
webapp/src/main/webapp/error.jsp 29ef640
webapp/src/main/webapp/login.html.template PRE-CREATION
webapp/src/main/webapp/login.jsp 70ec06d
Diff: https://reviews.apache.org/r/71623/diff/3/
Changes: https://reviews.apache.org/r/71623/diff/2-3/
Testing
-------
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
Tested in browser with simple mode.
Tested in browser with Knox proxy on kerberos mode.
Thanks,
Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218270
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java
Lines 50 (patched)
<https://reviews.apache.org/r/71623/#comment305916>
Refactor: Avoid 'if' clause.
webapp/src/main/webapp/WEB-INF/web.xml
Lines 40 (patched)
<https://reviews.apache.org/r/71623/#comment305917>
Relace AtlasHttpServlet with concrete class, say LoginServlet and ErrorServlet.
- Ashutosh Mestry
On Oct. 17, 2019, 10:51 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 10:51 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/2/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
> Tested in browser with simple mode.
> Tested in browser with Knox proxy on kerberos mode.
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/
-----------------------------------------------------------
(Updated Oct. 17, 2019, 10:51 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Added only one servlet which will handle both login and error pages.
Addressed review comments.
Bugs: ATLAS-3472
https://issues.apache.org/jira/browse/ATLAS-3472
Repository: atlas
Description
-------
This patch uses Servlets instead of JSP files to render login and error page.
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION
webapp/src/main/resources/spring-security.xml 1295244
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
webapp/src/main/webapp/error.html.template PRE-CREATION
webapp/src/main/webapp/error.jsp 29ef640
webapp/src/main/webapp/login.html.template PRE-CREATION
webapp/src/main/webapp/login.jsp 70ec06d
Diff: https://reviews.apache.org/r/71623/diff/2/
Changes: https://reviews.apache.org/r/71623/diff/1-2/
Testing (updated)
-------
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
Tested in browser with simple mode.
Tested in browser with Knox proxy on kerberos mode.
Thanks,
Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218232
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 29 (patched)
<https://reviews.apache.org/r/71623/#comment305831>
Refactor: Base class. Say, AtlasHttpServlet.
webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 38 (patched)
<https://reviews.apache.org/r/71623/#comment305830>
Refactor: Extract method with parameter. Consider passing the template as a parameter.
Code duplication at LoginServlet and ErrorServlet.
- Ashutosh Mestry
On Oct. 16, 2019, 12:49 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2019, 12:49 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218243
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java
Lines 30 (patched)
<https://reviews.apache.org/r/71623/#comment305884>
Rename class: "ErrorServlet" => "AtlasErrorServlet"
webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java
Lines 37 (patched)
<https://reviews.apache.org/r/71623/#comment305886>
update contentType from constant:
public final static String TEXT_HTML = "text/html";
webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 29 (patched)
<https://reviews.apache.org/r/71623/#comment305883>
+1 rename to AtlasLoginServlet
webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 36 (patched)
<https://reviews.apache.org/r/71623/#comment305885>
update contentType from constant:
public final static String TEXT_HTML = "text/html";
webapp/src/main/webapp/WEB-INF/web.xml
Lines 39 (patched)
<https://reviews.apache.org/r/71623/#comment305881>
nit: remove additional new line
webapp/src/main/webapp/WEB-INF/web.xml
Lines 60 (patched)
<https://reviews.apache.org/r/71623/#comment305882>
nit: remove additional new line
- Sarath Subramanian
On Oct. 16, 2019, 5:49 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2019, 5:49 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3472
> https://issues.apache.org/jira/browse/ATLAS-3472
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch uses Servlets instead of JSP files to render login and error page.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java PRE-CREATION
> webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java PRE-CREATION
> webapp/src/main/resources/spring-security.xml 1295244
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
> webapp/src/main/webapp/error.html.template PRE-CREATION
> webapp/src/main/webapp/error.jsp 29ef640
> webapp/src/main/webapp/login.html.template PRE-CREATION
> webapp/src/main/webapp/login.jsp 70ec06d
>
>
> Diff: https://reviews.apache.org/r/71623/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
>
>
> Thanks,
>
> Mandar Ambawane
>
>