You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by geetikagupta16 <gi...@git.apache.org> on 2018/02/07 10:47:43 UTC
[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...
GitHub user geetikagupta16 opened a pull request:
https://github.com/apache/carbondata/pull/1942
[CARBONDATA-2136] Fixed bug related to data load for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT
1. Refactored code for creating carbon row batch for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT
2. Added related test cases
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-2136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1942.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1942
----
commit 06de5ea9bcae5e60b22ee9530306b6951a3b9e00
Author: Geetika Gupta <ge...@...>
Date: 2018-02-07T10:42:09Z
1. Refactored code for creating carbon row batch for bad_record_action as REDIRECT or IGNORE and sort scope as NO_SORT
2. Added related test cases
----
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3558/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3965/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4610/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by geetikagupta16 <gi...@git.apache.org>.
Github user geetikagupta16 commented on the issue:
https://github.com/apache/carbondata/pull/1942
@mohammadshahidkhan I have added test cases for bucketing flow. Will be creating a new JIRA to handle streaming flow as it is throwing ClassCastException when data loading is performed with bad_record_action as IGNORE.
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3400/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3557/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5769/
---
[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1942#discussion_r168394055
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java ---
@@ -100,10 +103,17 @@ public void initialize() throws IOException {
* @return processed row.
*/
protected CarbonRowBatch processRowBatch(CarbonRowBatch rowBatch, RowConverter localConverter) {
+ String badRecordsAction = (String) configuration.getDataLoadProperty(BAD_RECORDS_LOGGER_ACTION);
while (rowBatch.hasNext()) {
CarbonRow convertRow = localConverter.convert(rowBatch.next());
- rowBatch.setPreviousRow(convertRow);
+ if (convertRow == null && (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
+ badRecordsAction.equals(LoggerAction.REDIRECT.toString()))) {
--- End diff --
Please remove check (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
badRecordsAction.equals(LoggerAction.REDIRECT.toString())
BadRecordsAction check is not required, only null check over convertRow is enough.
The convert method return's null only in case of bad_records_action is either IGNORE or REDIRECT.
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5175/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2508/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5998/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1942
LGTM
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3513/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4459/
---
[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1942
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3563/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2649/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3748/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3846/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4246/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by geetikagupta16 <gi...@git.apache.org>.
Github user geetikagupta16 commented on the issue:
https://github.com/apache/carbondata/pull/1942
@sraghunandan I have updated the PR template please check.
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/1942
+1 The streaming issue is handled in PR #2014
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2597/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by geetikagupta16 <gi...@git.apache.org>.
Github user geetikagupta16 commented on the issue:
https://github.com/apache/carbondata/pull/1942
retest this please
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by geetikagupta16 <gi...@git.apache.org>.
Github user geetikagupta16 commented on the issue:
https://github.com/apache/carbondata/pull/1942
@mohammadshahidkhan I have made the changes for bucketing. Please review
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3519/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4746/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by geetikagupta16 <gi...@git.apache.org>.
Github user geetikagupta16 commented on the issue:
https://github.com/apache/carbondata/pull/1942
retest this please
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1942
@geetikagupta16 pls update the PR template
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4282/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3626/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3842/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2321/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2601/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3406/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1942
retest this please
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3671/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3399/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3038/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3894/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/1942
LGTM
---
[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1942#discussion_r168395269
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java ---
@@ -100,10 +103,17 @@ public void initialize() throws IOException {
* @return processed row.
*/
protected CarbonRowBatch processRowBatch(CarbonRowBatch rowBatch, RowConverter localConverter) {
+ String badRecordsAction = (String) configuration.getDataLoadProperty(BAD_RECORDS_LOGGER_ACTION);
while (rowBatch.hasNext()) {
CarbonRow convertRow = localConverter.convert(rowBatch.next());
- rowBatch.setPreviousRow(convertRow);
+ if (convertRow == null && (badRecordsAction.equals(LoggerAction.IGNORE.toString()) ||
+ badRecordsAction.equals(LoggerAction.REDIRECT.toString()))) {
--- End diff --
@geetikagupta16 and @QiangCai
In case of bucketing and Stream Record writer also the same exist.
Please correct there as well.
For your reference:
1. For bucketing.
org/apache/carbondata/processing/loading/steps/DataConverterProcessorWithBucketingStepImpl.java:128
2. For Stream Record Writer
org/apache/carbondata/hadoop/streaming/CarbonStreamRecordWriter.java:191
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by SangeetaGulia <gi...@git.apache.org>.
Github user SangeetaGulia commented on the issue:
https://github.com/apache/carbondata/pull/1942
retest this please
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4839/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1942
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4247/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4740/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2326/
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/1942
@geetikagupta16
Please handle the same issue in case of Stream Record writer as well.
Currently there no test case for the bucketing flow to validate the issue handled as part of this PR.
Please add the test cases to verify the bucketing and also streaming flow.
---
[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1942
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2320/
---