[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5459: Add support to encrypt https.keystore.password in server.properties

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5459:
URL: https://github.com/apache/cloudstack/pull/5459#discussion_r709926052



##########
File path: client/src/main/java/org/apache/cloudstack/ServerDaemon.java
##########
@@ -116,7 +116,7 @@ public void init(final DaemonContext context) {
         LOG.info("Server configuration file found: " + confFile.getAbsolutePath());
 
         try {
-            final Properties properties = PropertiesUtil.loadFromFile(confFile);
+            final Properties properties = ServerProperties.getServerProperties();

Review comment:
       @Pearl1594 `confFile` object here is only used for getting properties from "_server.properties_".  Can you remove / move the lines above ( L#109 - L#116) to ServerProperties class as applicable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org