[jira] [Commented] (AMBARI-13965) Ambari CS View "Ambari Cluster URL" setting regex is too restrictive

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013407#comment-15013407 ] 

Hadoop QA commented on AMBARI-13965:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12773214/AMBARI-13965_branch-2.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in contrib/views/capacity-scheduler.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/4336//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/4336//console

This message is automatically generated.

> Ambari CS View "Ambari Cluster URL" setting regex is too restrictive
> --------------------------------------------------------------------
>
>                 Key: AMBARI-13965
>                 URL: https://issues.apache.org/jira/browse/AMBARI-13965
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-views
>    Affects Versions: 2.1.1
>            Reporter: DIPAYAN BHOWMICK
>             Fix For: 2.1.3
>
>         Attachments: AMBARI-13965_branch-2.1.patch
>
>
> PROBLEM: When configuring the Capacity Scheduler view the customer had to manually define the ambari server url because normally they access ambari server over SSL through an alias, which is defined in the commonName of the SSL cert.
> The customer's hostname and cluster name have a - in them. This fails the regex and therefore the host can't be updated. Since the validator code is running on the server side and not in Javacript, even if we were to use the REST API to update this it would be the same one Ambari is already using so I see no workaround for this other than to directly manipulate the database.
> Specifically the validation I'm talking about is here:
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java
> This regex needs to be relaxed, and ideally if this validation is going to be done it should be using whatever rules used in Ambari elsewhere. For example if I can create the host or cluster in Ambari to start with then such a name should never fail a validation rule anywhere else in Ambari ever for any reason.
> Url like http://c1-node.local:8080/api/v1/clusters/c1 were failing because of the hyphen in the URL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)