You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/31 06:44:50 UTC
[GitHub] [spark] teeyog commented on issue #25287:
[SPARK-28552][SQL]Identification of different dialects insensitive to case
by JDBC URL prefix
teeyog commented on issue #25287: [SPARK-28552][SQL]Identification of different dialects insensitive to case by JDBC URL prefix
URL: https://github.com/apache/spark/pull/25287#issuecomment-516720139
@maropu Thank you very much for your guidance. I will improve this PR description. In addition, you suggest that URL be converted to lowercase only through JdbcDialect without modifying the logic of dialects. I have not thought of a better way to implement it, or to control the incoming url, which is already lowercase, but I don't think that's very good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org