You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/03/15 08:18:23 UTC
Review Request 44838: Enabled mesos containerizer force_pull_image for
docker.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886
Repository: mesos
Description
-------
Enabled mesos containerizer force_pull_image for docker.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
Diff: https://reviews.apache.org/r/44838/diff/
Testing
-------
make
make check
It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
Thanks,
Guangya Liu
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123622
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On March 15, 2016, 7:55 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 7:55 a.m.)
>
>
> Review request for mesos, haosdent huang and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
-----------------------------------------------------------
(Updated 四月 18, 2016, 8:31 a.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886
Repository: mesos
Description
-------
Enabled mesos containerizer force_pull_image for docker.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
Diff: https://reviews.apache.org/r/44838/diff/
Testing
-------
make
make check
It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
Thanks,
Guangya Liu
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/
-----------------------------------------------------------
(Updated 三月 15, 2016, 7:55 a.m.)
Review request for mesos, haosdent huang and Jie Yu.
Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886
Repository: mesos
Description
-------
Enabled mesos containerizer force_pull_image for docker.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
Diff: https://reviews.apache.org/r/44838/diff/
Testing
-------
make
make check
It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
Thanks,
Guangya Liu
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by haosdent huang <ha...@gmail.com>.
> On March 15, 2016, 7:42 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188
> > <https://reviews.apache.org/r/44838/diff/1/?file=1299389#file1299389line188>
> >
> > Because we don't set default value of `force_pull_image` in protobuf file. Seems here would be `false`. It is a excepted behaviour, right?
>
> Guangya Liu wrote:
> Yes, there is already a similar parameter here https://reviews.apache.org/r/28190 for docker containerizer, I was using similar logic to handle it in mesos containerizer.
Got it. Thank you for explanation.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123614
-----------------------------------------------------------
On March 15, 2016, 7:55 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 7:55 a.m.)
>
>
> Review request for mesos, haosdent huang and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by Guangya Liu <gy...@gmail.com>.
> On 三月 15, 2016, 7:42 a.m., haosdent huang wrote:
> > And seems don't contains `appc` part in this patch?
AppC will be handled in the following patch.
> On 三月 15, 2016, 7:42 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188
> > <https://reviews.apache.org/r/44838/diff/1/?file=1299389#file1299389line188>
> >
> > Because we don't set default value of `force_pull_image` in protobuf file. Seems here would be `false`. It is a excepted behaviour, right?
Yes, there is already a similar parameter here https://reviews.apache.org/r/28190 for docker containerizer, I was using similar logic to handle it in mesos containerizer.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123614
-----------------------------------------------------------
On 三月 15, 2016, 7:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated 三月 15, 2016, 7:18 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123614
-----------------------------------------------------------
And seems don't contains `appc` part in this patch?
src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 188)
<https://reviews.apache.org/r/44838/#comment185852>
Because we don't set default value of `force_pull_image` in protobuf file. Seems here would be `false`. It is a excepted behaviour, right?
- haosdent huang
On March 15, 2016, 7:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 7:18 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by Guangya Liu <gy...@gmail.com>.
> On 三月 15, 2016, 7:34 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp, line 93
> > <https://reviews.apache.org/r/44838/diff/1/?file=1299387#file1299387line93>
> >
> > Should we have default value for `forcePullImage`, for example: `forcePullImage=false`.
Actually, the default value does not make much sense here as we always put this parameter in.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123612
-----------------------------------------------------------
On 三月 15, 2016, 7:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated 三月 15, 2016, 7:18 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 44838: Enabled mesos containerizer
force_pull_image for docker.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123612
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp (line 93)
<https://reviews.apache.org/r/44838/#comment185848>
Should we have default value for `forcePullImage`, for example: `forcePullImage=false`.
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 167)
<https://reviews.apache.org/r/44838/#comment185850>
Maybe we need log `forcePullImage` option in this log item.
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 169)
<https://reviews.apache.org/r/44838/#comment185849>
I suggest change
```
!storedImages.contains(imageReference) || forcePullImage
```
to
```
forcePullImage || !storedImages.contains(imageReference)
```
So that we don't need search `storedImages` if `forcePullImage` is true.
- haosdent huang
On March 15, 2016, 7:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 7:18 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled mesos containerizer force_pull_image for docker.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp cf630cc0b67a325529fa04ad2b1708e013b9596a
> src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96
>
> Diff: https://reviews.apache.org/r/44838/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> It is difficult to test this with unit test, but just test with mesos execute by setting `force_pull_image` as true and found that the iamge was always pulled when `force_pull_image` is true.
>
>
> Thanks,
>
> Guangya Liu
>
>