You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/14 12:48:58 UTC

[GitHub] [rocketmq-client-go] murDDock opened a new pull request #535: fix(remote_client):avoid goroutine leak

murDDock opened a new pull request #535:
URL: https://github.com/apache/rocketmq-client-go/pull/535


   Change-Id: Ifa0555c45529f84720ef885e5f803f8633e65968
   
   What is the purpose of the change
   fix the goroutine leak for remotingClient.
   In the case that ResponseFuture timed out, goroutine would be leak.
   
   Brief changelog
   if ResponseFuture times out，DONE channel should be closed。


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] xujianhai666 commented on pull request #535: fix(remote_client):avoid goroutine leak

Posted by GitBox <gi...@apache.org>.

xujianhai666 commented on pull request #535:
URL: https://github.com/apache/rocketmq-client-go/pull/535#issuecomment-734098791


   lgtm. we have use same fix at bytedance


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] xujianhai666 merged pull request #535: fix(remote_client):avoid goroutine leak

Posted by GitBox <gi...@apache.org>.

xujianhai666 merged pull request #535:
URL: https://github.com/apache/rocketmq-client-go/pull/535


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org