[GitHub] flink pull request #3810: [FLINK-6397] MultipleProgramsTestBase does not res...

[ifndef-SleePy <gi...@git.apache.org>]

Github user ifndef-SleePy commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3810#discussion_r115133175
  
    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java ---
    @@ -80,29 +80,36 @@
     	
     	protected final TestExecutionMode mode;
     
    -	
    +	private TestEnvironment testEnvironment;
    +
    +	private CollectionTestEnvironment collectionTestEnvironment;
    +
     	public MultipleProgramsTestBase(TestExecutionMode mode) {
     		this.mode = mode;
    -		
    +
     		switch(mode){
     			case CLUSTER:
    -				new TestEnvironment(cluster, 4).setAsContext();
    +				testEnvironment = new TestEnvironment(cluster, 4);
    --- End diff --
    
    @zentol I just found that I can not move these codes into \@Before method, because it will not work with JUnit Parameterized. I proposal to keep these codes in constructor. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---