You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:53:33 UTC
[GitHub] [activemq-artemis] pahamala opened a new pull request #3826: ARTEMIS-3140 Extra options in LDAP login module
pahamala opened a new pull request #3826:
URL: https://github.com/apache/activemq-artemis/pull/3826
Adds support for extra configuration options to LDAP login module to
prepare for supporting any future/custom string configuration in LDAP
directory context creation. Includes also fixes for issues reported by
static analysis tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3826: ARTEMIS-3140 Extra options in LDAP login module
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3826:
URL: https://github.com/apache/activemq-artemis/pull/3826#issuecomment-954914295
@pahamala, this is a very nice contribution! I've been meaning to implement a similarly generic solution for awhile now. Thanks so much for sending this PR. I'm surprised it's your first (according to your GitHub account).
I'm going to let the PR build finish, and then I'll merge it if there are no issues. I'll probably amend your commit to add the bulleted list of details you provided to the commit message so all this is preserved in the repo directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3826: ARTEMIS-3140 Extra options in LDAP login module
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3826:
URL: https://github.com/apache/activemq-artemis/pull/3826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] pahamala commented on pull request #3826: ARTEMIS-3140 Extra options in LDAP login module
Posted by GitBox <gi...@apache.org>.
pahamala commented on pull request #3826:
URL: https://github.com/apache/activemq-artemis/pull/3826#issuecomment-955974275
Thanks @jbertram, glad to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org