You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/03 02:39:04 UTC

[GitHub] [flink] zhijiangW commented on issue #7197: [FLINK-12909][flink-runtime][network] continue trying to find a suitable spilling channel even in case of exceptions

zhijiangW commented on issue #7197: [FLINK-12909][flink-runtime][network] continue trying to find a suitable spilling channel even in case of exceptions
URL: https://github.com/apache/flink/pull/7197#issuecomment-507915036
 
 
   Thanks for the further reviews @NicoK !
   Sorry for missing your previous comment of unit test. I also think it is better to add a test for covering this change. We might construct the `SpillingAdaptiveSpanningRecordDeserializer` with some invalid `tmpDirectories`. Then we could verify the attempt retry work in `createSpillingChannel`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services