You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openoffice.apache.org by Lin Yuan <yu...@gmail.com> on 2012/06/14 15:22:35 UTC

[Call for Review] Issue 119945 - Application crashed if undo adding caption to drawing object in sw

I have submit a patch to fix issue 119945. It's a crash issue when user do
"group","ungroup","add caption" operations for two drawing objects and then
do undo.

Detail issue info and comments of this issue please refer to
https://issues.apache.org/ooo/show_bug.cgi?id=119945
Patch info please refer to
https://issues.apache.org/ooo/attachment.cgi?id=78310

Please help review this fix. Thanks.

Thanks,
Lin Yuan

Re: [Call for Review] Issue 119945 - Application crashed if undo adding caption to drawing object in sw

Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.

Hi,

On 21.06.2012 14:58, Oliver-Rainer Wittmann wrote:
> Hi,
>
> On 14.06.2012 15:22, Lin Yuan wrote:
>> I have submit a patch to fix issue 119945. It's a crash issue when user do
>> "group","ungroup","add caption" operations for two drawing objects and then
>> do undo.
>>
>> Detail issue info and comments of this issue please refer to
>> https://issues.apache.org/ooo/show_bug.cgi?id=119945
>> Patch info please refer to
>> https://issues.apache.org/ooo/attachment.cgi?id=78310
>>
>> Please help review this fix. Thanks.
>>
>
> I am taking over the issue to review the patch.
>

Patch works fine
--> applied to trunk, revision 1352786

Thx for the patch, Oliver.

Re: [Call for Review] Issue 119945 - Application crashed if undo adding caption to drawing object in sw

Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.

Hi,

On 14.06.2012 15:22, Lin Yuan wrote:
> I have submit a patch to fix issue 119945. It's a crash issue when user do
> "group","ungroup","add caption" operations for two drawing objects and then
> do undo.
>
> Detail issue info and comments of this issue please refer to
> https://issues.apache.org/ooo/show_bug.cgi?id=119945
> Patch info please refer to
> https://issues.apache.org/ooo/attachment.cgi?id=78310
>
> Please help review this fix. Thanks.
>

I am taking over the issue to review the patch.

Best regards, Oliver.