[jira] [Commented] (ZOOKEEPER-2191) Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544969#comment-14544969 ] 

Hadoop QA commented on ZOOKEEPER-2191:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12733065/ZOOKEEPER-2191.001.patch
  against trunk revision 1679489.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2699//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2699//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2699//console

This message is automatically generated.

> Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2191
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2191
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: ZOOKEEPER-2191.001.patch
>
>
> ZOOKEEPER-2183 introduced usage of the threads attribute on the <junit> task call in build.xml to speed up test execution.  This attribute is only available since Ant 1.9.4.  However, we can continue to support older Ant versions by calling the <antversion> task and dispatching to a clone of our <junit> task call that doesn't use the threads attribute.  Users of older Ant versions will get the slower single-process test execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)