You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/28 23:24:03 UTC

[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8363: [Tuning] Allow multiprocessing spawn to work (on macOS llvm at least)

AndrewZhaoLuo edited a comment on pull request #8363:
URL: https://github.com/apache/tvm/pull/8363#issuecomment-870093432


   Still a draft, there still is a problem with `src/target/target.cc` construction. 
   
   ```
   Target::Target(Target target, Target host) {
     ObjectPtr<TargetNode> n = make_object<TargetNode>(*target.get());
     CHECK(!n->host.defined() || n->host.same_as(host))
         << "ValueError: Adding a host to a target whose host field has been defined target: "
         << n->host << " host: " << host << " ptr target: " << n.get()
         << " ptr host: " << make_object<TargetNode>(*host.get()).get();
     ;
     // add target host into host field
     n->host = std::move(host);
     data_ = std::move(n);
   }
   ```
   Check failed
   Spawn breaks pointer equality which was the assumption. We now need a deep equality thing for "tvm::Target" I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org