[jira] [Assigned] (WICKET-6178) MetaDataHeaderItem # generateString() should return specials characters escaped like StringEscapeUtils.escapeHtml(s) does

["Andrea Del Bene (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrea Del Bene reassigned WICKET-6178:
---------------------------------------

    Assignee: Andrea Del Bene

> MetaDataHeaderItem # generateString() should return specials characters escaped like StringEscapeUtils.escapeHtml(s) does
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-6178
>                 URL: https://issues.apache.org/jira/browse/WICKET-6178
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.3.0
>            Reporter: francois
>            Assignee: Andrea Del Bene
>            Priority: Minor
>
> I think MetaDataHeaderItem # generateString() should return specials characters escaped like 
> StringEscapeUtils.escapeHtml(s) does. 
> Apache Wicket 7.3.0 - MetaDataHeaderItem  - Line 126 : append(JavaScriptUtils.escapeQuotes(value.toString())) 
> return qwerty'qwerty as qwerty\’qwerty 
> I would like the return to be qwerty'qwerty (for example for the metatag description). 
> Martin's answer : 
> Looking at 
> https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127
> I agree that only double quotes should be escaped because only double 
> quotes may end prematurely the value. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)