You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2011/06/02 18:33:47 UTC

[jira] [Created] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

ant binary fails due to missing c++ lib dir
-------------------------------------------

                 Key: MAPREDUCE-2559
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: build
    Affects Versions: 0.20.3
         Environment: Redhat 5.5, Java 6
            Reporter: Eric Yang
             Fix For: 0.23.0


Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated MAPREDUCE-2559:
---------------------------------

    Attachment: MAPREDUCE-2559-2.patch

Option #2, "ant binary" compiles pipes, and task-controller and utils.  librecordio is not completed unless -Dlibrecordio and -Dxercescroot is defined.

At this point, it's a pick and choose.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043022#comment-13043022 ] 

Hadoop QA commented on MAPREDUCE-2559:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481258/MAPREDUCE-2559.patch
  against trunk revision 1130554.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/335//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/335//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/335//console

This message is automatically generated.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated MAPREDUCE-2559:
-----------------------------------

    Attachment: mapreduce-2559-4.patch

I filed HDFS-2040 to make HDFS more consistent with Common and MR (where ant binary only builds native code if passed a flag). See that jira for rationale.
 
Attaching mapreduce-2559-4.patch, minimal patch to allow ant binary to build the tarball as it did previously.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043113#comment-13043113 ] 

Eli Collins commented on MAPREDUCE-2559:
----------------------------------------

Agree that we should not automatically compile librecordio since it does not build out of the box (we don't bundle it's dependency).  I'm fine if MR wants to keep the compilation contigent on compile.c++ being passed (note that compile.native is just in common), though given that ant binary is supposed to produce a binary tarball it seems like it should build all the binaries. Is the concern that there should be a target that produces a tarball w/ just java code? Newcomers can always use ant jar to build just the java code (assuming they don't need a tarball). 

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045739#comment-13045739 ] 

Hudson commented on MAPREDUCE-2559:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #719 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/719/])
    MAPREDUCE-2559. ant binary fails due to missing c++ lib dir. Contributed by Eli Collins

eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1133226
Files : 
* /hadoop/mapreduce/trunk/CHANGES.txt
* /hadoop/mapreduce/trunk/build.xml


> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043123#comment-13043123 ] 

Todd Lipcon commented on MAPREDUCE-2559:
----------------------------------------

For doing a full release binary tarball, "ant binary" is still not sufficient, since it makes a platform-specific tarball -- the native code is only compiled for the architecture on which you're running, unless you pass some CXXFLAGS and CFLAGS environments.

Plus, "ant binary" is useful for people who want to distribute a tarball around their cluster - it's the full "dist dir" minus the native stuff which some folks may not require.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045726#comment-13045726 ] 

Todd Lipcon commented on MAPREDUCE-2559:
----------------------------------------

+1 here.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043133#comment-13043133 ] 

Eric Yang commented on MAPREDUCE-2559:
--------------------------------------

For secure version of hadoop, task-controller is essential.  Secure hadoop should be the default for future version of hadoop, hence, I would vote for MAPREDUCE-2559-2.patch instead of MAPREDUCE-2559-3.patch.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated MAPREDUCE-2559:
---------------------------------

    Attachment: MAPREDUCE-2559-3.patch

In HDFS-2022, HDFS community decided to change binary target to depends on libhdfs.  Hence, it may be good to be consistent that binary target compiles c++ and native code.  However, here is another patch that will avoid compile of any c++ code for binary target unless specified -Dcompile.* flags.  Just in case.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057263#comment-13057263 ] 

Hudson commented on MAPREDUCE-2559:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #722 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/])
    

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated MAPREDUCE-2559:
---------------------------------

    Attachment: MAPREDUCE-2559.patch

Enforce binary target to depends on compile.c++.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated MAPREDUCE-2559:
---------------------------------

    Attachment: MAPREDUCE-2559-1.patch

Option #1, ant binary must provide -D for a proper build, or the build fails with this message:

{noformat}
check-xercescroot:

BUILD FAILED
/home/eyang/sandbox/hadoop/git/hadoop-mapreduce/build.xml:1826: 'xercescroot' is not defined.  Please pass -Dxercescroot=<base of xerces 2.8.0 installation> to Ant on the command-line.
{noformat}

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043080#comment-13043080 ] 

Todd Lipcon commented on MAPREDUCE-2559:
----------------------------------------

I prefer to keep it as it was before -- if you don't specify -Dcompile.c++=1 and -Dcompile.native=1, it didn't compile any native code, right?

Strongly against the option that requires xerces, since librecordio is used only by a very tiny subset of users, and is as far as I know deprecated for quite some time.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated MAPREDUCE-2559:
---------------------------------

    Assignee: Eric Yang
      Status: Patch Available  (was: Open)

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045239#comment-13045239 ] 

Hadoop QA commented on MAPREDUCE-2559:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481640/mapreduce-2559-4.patch
  against trunk revision 1132807.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI
                  org.apache.hadoop.fs.TestFileSystem

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/352//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/352//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/352//console

This message is automatically generated.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042980#comment-13042980 ] 

Eric Yang commented on MAPREDUCE-2559:
--------------------------------------

librecordio requires xerces.  For librecordio to compile, path to xerces must be defined in build.properties.  I am trying to make "ant binary" as new comer proof as possible as suggested by Amar Kamat in MAPREDUCE-2521.  Hence, task-controller and librecordio are not included to lower the barrier of entry.  It would be easy to include librecordio and task-controller, if more people comments on this jira that is the right thing to do.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045297#comment-13045297 ] 

Eli Collins commented on MAPREDUCE-2559:
----------------------------------------

I think the findbugs and test failures are unrelated to this patch.

Eric, Todd - does this patch and the one on HDFS-2040 look reasonable to you guys?

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045516#comment-13045516 ] 

Eric Yang commented on MAPREDUCE-2559:
--------------------------------------

+1 on this patch, but HDFS-2040 patch may have problem.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043147#comment-13043147 ] 

Hadoop QA commented on MAPREDUCE-2559:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481285/MAPREDUCE-2559-2.patch
  against trunk revision 1130554.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/337//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/337//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/337//console

This message is automatically generated.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043051#comment-13043051 ] 

Eric Yang commented on MAPREDUCE-2559:
--------------------------------------

Sorry, incompleted statement in -D in previous message.  Usage:

{noformat}
ant clean binary -Dxercescroot=/path/to/xercescroot
{noformat}

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043167#comment-13043167 ] 

Hadoop QA commented on MAPREDUCE-2559:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481297/MAPREDUCE-2559-3.patch
  against trunk revision 1130554.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/339//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/339//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/339//console

This message is automatically generated.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042936#comment-13042936 ] 

Eli Collins commented on MAPREDUCE-2559:
----------------------------------------

Shouldn't the binary target build all the c++ targets, including task-contoller and librecordio? IIUC this will just build pipes, utils and examples.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2559) ant binary fails due to missing c++ lib dir

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated MAPREDUCE-2559:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I've committed this. Thanks Eric and Todd.

> ant binary fails due to missing c++ lib dir
> -------------------------------------------
>
>                 Key: MAPREDUCE-2559
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2559
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.3
>         Environment: Redhat 5.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2559-1.patch, MAPREDUCE-2559-2.patch, MAPREDUCE-2559-3.patch, MAPREDUCE-2559.patch, mapreduce-2559-4.patch
>
>
> Post MAPRED-2521 ant binary fails without "-Dcompile.c++=true -Dcompile.native=true". The bin-package is trying to copy from the c++ lib dir which doesn't exist yet. The binary target should check for the existence of this dir or would also be reasonable to depend on the compile-c++ (since this is the binary target).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira