You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/25 00:16:33 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #22846: Combining state integration test

damccorm commented on code in PR #22846:
URL: https://github.com/apache/beam/pull/22846#discussion_r954396578


##########
sdks/go/test/integration/primitives/state.go:
##########
@@ -126,3 +132,120 @@ func BagStateParDo() *beam.Pipeline {
 
 	return p
 }
+
+type combiningStateFn struct {
+	State0 state.Combining[int, int, int]
+	State1 state.Combining[int, int, int]
+	State2 state.Combining[string, string, int]
+	State3 state.Combining[string, string, int]
+	State4 state.Combining[int, int, int]
+}
+
+type accum1 struct{}
+
+func (ac *accum1) MergeAccumulators(a, b int) int {
+	return a + b
+}
+
+type accum2 struct{}

Review Comment:
   Yeah, that's fair - I updated to combine*



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org