You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/09 17:32:15 UTC
[GitHub] [superset] amitmiran137 opened a new pull request #16150: feat: EXTRA_CACHING_STRATEGIES
amitmiran137 opened a new pull request #16150:
URL: https://github.com/apache/superset/pull/16150
### SUMMARY
Superset enables us to run different caching strategies under celery beat.
The ability here is to provide additional strategies from the config that can later be run
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42367 +1647
- Misses 12295 12629 +334
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.66% <60.41%> (+0.09%)` | :arrow_up: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #16150:
URL: https://github.com/apache/superset/pull/16150#discussion_r690553544
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
Review comment:
Instead of `EXTRA_CACHING_STRATEGIES`, we should have `CACHING_STRATEGIES`, which is set to a default set of strategies. This way, downstreams can override the complete set of strategies easily.
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
Review comment:
No `f-strings` in log messages.
Nit: `Cache warmup strategy xxx not found`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
Review comment:
Should be `DEBUG`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
+ try:
+ strategy = class_(*args, **kwargs)
+ logger.info("Success!")
+ except TypeError:
+ message = "Error loading strategy!"
+ logger.exception(message)
+ return message
Review comment:
Why return, just raise?
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
Review comment:
This should be `DEBUG` and should have a little more context - like `Running cache warmup strategy x...`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
+ try:
+ strategy = class_(*args, **kwargs)
+ logger.info("Success!")
+ except TypeError:
+ message = "Error loading strategy!"
+ logger.exception(message)
+ return message
+
+ results: Dict[str, List[str]] = {"success": [], "errors": []}
+ for url in strategy.get_urls():
+ try:
+ logger.info("Fetching %s", url)
+ request.urlopen(url) # pylint: disable=consider-using-with
Review comment:
How does this deal with auth? I'm assuming most of these charts will live behind some auth mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (919c36d) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42367 +1647
- Misses 12295 12629 +334
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.66% <60.41%> (+0.09%)` | :arrow_up: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head 19b0841. Consider uploading reports for the commit 19b0841 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...19b0841](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (919c36d) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42364 +1644
- Misses 12295 12632 +337
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.48% <60.41%> (-0.08%)` | :arrow_down: |
| postgres | `81.47% <60.41%> (-0.12%)` | :arrow_down: |
| python | `81.76% <60.41%> (+0.08%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3713b1) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...b3713b1](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/3709131089ba866de534c0f3765a8e1123df0204?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3709131) will **not change** coverage.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.70% 76.70%
=======================================
Files 997 997
Lines 53240 53240
Branches 6774 6774
=======================================
Hits 40838 40838
Misses 12172 12172
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3709131...887fe2a](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4fbbb84) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **decrease** coverage by `0.15%`.
> The diff coverage is `60.34%`.
> :exclamation: Current head 4fbbb84 differs from pull request most recent head 6eb5dbb. Consider uploading reports for the commit 6eb5dbb to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
- Coverage 76.83% 76.68% -0.16%
==========================================
Files 995 996 +1
Lines 52884 52921 +37
Branches 6721 6721
==========================================
- Hits 40636 40583 -53
- Misses 12023 12113 +90
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.56% <65.78%> (-0.02%)` | :arrow_down: |
| postgres | `?` | |
| presto | `81.42% <65.78%> (-0.02%)` | :arrow_down: |
| python | `81.81% <65.78%> (-0.31%)` | :arrow_down: |
| sqlite | `81.18% <65.78%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.07% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `75.00% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `82.94% <ø> (ø)` | |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.27% <0.00%> (-0.64%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `44.53% <11.11%> (ø)` | |
| [superset/utils/profiler.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcHJvZmlsZXIucHk=) | `47.05% <47.05%> (ø)` | |
| [...plore/components/controls/OptionControls/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9PcHRpb25Db250cm9scy9pbmRleC50c3g=) | `90.42% <66.66%> (ø)` | |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.72% <75.00%> (-0.19%)` | :arrow_down: |
| [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `92.68% <85.71%> (-0.66%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...6eb5dbb](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eb5dbb) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **increase** coverage by `0.12%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.83% 76.96% +0.12%
==========================================
Files 995 996 +1
Lines 52884 53248 +364
Branches 6721 6721
==========================================
+ Hits 40636 40984 +348
- Misses 12023 12039 +16
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.23% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.14% <100.00%> (+1.89%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.27% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/utils/profiler.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcHJvZmlsZXIucHk=) | `47.05% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `93.46% <0.00%> (+0.50%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `86.58% <0.00%> (+0.87%)` | :arrow_up: |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `90.90% <0.00%> (+2.99%)` | :arrow_up: |
| [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `97.00% <0.00%> (+3.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...6eb5dbb](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (919c36d) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.36%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.84% +0.36%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42439 +1719
- Misses 12295 12557 +262
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.24% <60.41%> (?)` | |
| javascript | `70.94% <ø> (ø)` | |
| mysql | `81.66% <60.41%> (+0.09%)` | :arrow_up: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `82.02% <60.41%> (+0.34%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head e2e7a3b. Consider uploading reports for the commit e2e7a3b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...e2e7a3b](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...90df140](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (919c36d) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **decrease** coverage by `0.05%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
- Coverage 76.47% 76.41% -0.06%
==========================================
Files 997 1002 +5
Lines 53245 53273 +28
Branches 6777 6777
==========================================
- Hits 40720 40710 -10
- Misses 12295 12333 +38
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `81.47% <60.41%> (-0.12%)` | :arrow_down: |
| python | `81.55% <60.41%> (-0.12%)` | :arrow_down: |
| sqlite | `81.15% <60.41%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `94.04% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.37% <0.00%> (-0.78%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.22%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head b3713b1. Consider uploading reports for the commit b3713b1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.70% +0.22%
==========================================
Files 997 997
Lines 53245 53240 -5
Branches 6777 6774 -3
==========================================
+ Hits 40720 40838 +118
+ Misses 12295 12172 -123
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <0.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.88% <0.00%> (+0.23%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.40% <0.00%> (+0.25%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...b3713b1](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42366 +1646
- Misses 12295 12630 +335
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.48% <60.41%> (-0.08%)` | :arrow_down: |
| postgres | `81.51% <60.41%> (-0.08%)` | :arrow_down: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42366 +1646
- Misses 12295 12630 +335
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.48% <60.41%> (-0.08%)` | :arrow_down: |
| postgres | `81.55% <60.41%> (-0.04%)` | :arrow_down: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-1002917271
hi @amitmiran137 I see this was closed without merge.
I have few questions here.
* it calls charts explore url and request lib doesn't load javascript so it doesn’t really gets the data from endpoint which is POST explore_json or POST data which actually loads data into cache.
* also this won't generate thumbnail urls.
so should we just invoke headless driver like we do for reports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head 70756ac. Consider uploading reports for the commit 70756ac to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...70756ac](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (beab7dc) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.01%`.
> The diff coverage is `66.84%`.
> :exclamation: Current head beab7dc differs from pull request most recent head 919c36d. Consider uploading reports for the commit 919c36d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.49% +0.01%
==========================================
Files 997 1002 +5
Lines 53245 53272 +27
Branches 6777 6777
==========================================
+ Hits 40720 40750 +30
+ Misses 12295 12292 -3
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.27% <66.84%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `81.34% <66.84%> (?)` | |
| python | `81.70% <66.84%> (+0.02%)` | :arrow_up: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <ø> (+1.65%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `93.03% <ø> (ø)` | |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `89.94% <ø> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.23% <ø> (-2.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.75% <ø> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `90.24% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `94.04% <ø> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <ø> (+6.48%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `85.18% <ø> (+85.18%)` | :arrow_up: |
| ... and [64 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.26%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head 6eaeb2e. Consider uploading reports for the commit 6eaeb2e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.43% 76.70% +0.26%
==========================================
Files 997 997
Lines 53205 53240 +35
Branches 6777 6774 -3
==========================================
+ Hits 40669 40838 +169
+ Misses 12306 12172 -134
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <0.00%> (-0.31%)` | :arrow_down: |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...6eaeb2e](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #16150:
URL: https://github.com/apache/superset/pull/16150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.22%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head 1888aff. Consider uploading reports for the commit 1888aff to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.70% +0.22%
==========================================
Files 997 997
Lines 53245 53240 -5
Branches 6777 6774 -3
==========================================
+ Hits 40720 40838 +118
+ Misses 12295 12172 -123
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <0.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.88% <0.00%> (+0.23%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.40% <0.00%> (+0.25%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...1888aff](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
mayurnewase edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-1002917271
hi @amitmiran137 I see this was closed without merge, what was the reason?
I have few questions here.
* it calls charts explore url and request lib doesn't load javascript so it doesn’t really gets the data from endpoint which is POST explore_json or POST data which actually loads data into cache.
* also this won't generate thumbnail urls, which would be usefull to warm up as well.
so should we just invoke headless driver like we do for reports?
I can help take over this along with fixing authentication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head 80ad939. Consider uploading reports for the commit 80ad939 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...80ad939](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #16150:
URL: https://github.com/apache/superset/pull/16150#discussion_r690553544
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
Review comment:
Instead of `EXTRA_CACHING_STRATEGIES`, we should have `CACHING_STRATEGIES`, which is set to a default set of strategies. This way, downstreams can override the complete set of strategies easily.
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
Review comment:
No `f-strings` in log messages.
Nit: `Cache warmup strategy xxx not found`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
Review comment:
Should be `DEBUG`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
+ try:
+ strategy = class_(*args, **kwargs)
+ logger.info("Success!")
+ except TypeError:
+ message = "Error loading strategy!"
+ logger.exception(message)
+ return message
Review comment:
Why return, just raise?
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
Review comment:
This should be `DEBUG` and should have a little more context - like `Running cache warmup strategy x...`
##########
File path: superset/tasks/caching/cache.py
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=too-few-public-methods
+
+import logging
+from typing import Any, Dict, List, Type, Union
+from urllib import request
+from urllib.error import URLError
+
+from celery.utils.log import get_task_logger
+
+from superset import app
+from superset.extensions import celery_app
+from superset.tasks.caching.strategies.dashboard_tags import DashboardTagsStrategy
+from superset.tasks.caching.strategies.dummy import DummyStrategy
+from superset.tasks.caching.strategies.top_n import TopNDashboardsStrategy
+from superset.tasks.caching.strategy import Strategy
+
+logger = get_task_logger(__name__)
+logger.setLevel(logging.INFO)
+
+
+strategies: List[Type[Strategy]] = [
+ DummyStrategy,
+ TopNDashboardsStrategy,
+ DashboardTagsStrategy,
+]
+
+
+@celery_app.task(name="cache-warmup")
+def cache_warmup(
+ strategy_name: str, *args: Any, **kwargs: Any # pylint: disable=unused-argument
+) -> Union[Dict[str, List[str]], str]:
+ """
+ Warm up cache.
+
+ This task periodically hits charts to warm up the cache.
+
+ """
+ logger.info("Loading strategy")
+ class_ = None
+ extra_strategies: List[Type[Strategy]] = app.config["EXTRA_CACHING_STRATEGIES"]
+ for class_ in strategies + extra_strategies:
+ if class_.__name__ == strategy_name:
+ break
+ else:
+ message = f"No strategy {strategy_name} found!"
+ logger.error(message, exc_info=True)
+ return message
+
+ logger.info("Loading %s", class_.__name__)
+ try:
+ strategy = class_(*args, **kwargs)
+ logger.info("Success!")
+ except TypeError:
+ message = "Error loading strategy!"
+ logger.exception(message)
+ return message
+
+ results: Dict[str, List[str]] = {"success": [], "errors": []}
+ for url in strategy.get_urls():
+ try:
+ logger.info("Fetching %s", url)
+ request.urlopen(url) # pylint: disable=consider-using-with
Review comment:
How does this deal with auth? I'm assuming most of these charts will live behind some auth mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.22%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head 6b5cd91. Consider uploading reports for the commit 6b5cd91 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.70% +0.22%
==========================================
Files 997 997
Lines 53245 53240 -5
Branches 6777 6774 -3
==========================================
+ Hits 40720 40838 +118
+ Misses 12295 12172 -123
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <0.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.88% <0.00%> (+0.23%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.40% <0.00%> (+0.25%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...6b5cd91](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4fbbb84) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **decrease** coverage by `0.15%`.
> The diff coverage is `60.34%`.
> :exclamation: Current head 4fbbb84 differs from pull request most recent head 45888ea. Consider uploading reports for the commit 45888ea to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
- Coverage 76.83% 76.68% -0.16%
==========================================
Files 995 996 +1
Lines 52884 52921 +37
Branches 6721 6721
==========================================
- Hits 40636 40583 -53
- Misses 12023 12113 +90
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.56% <65.78%> (-0.02%)` | :arrow_down: |
| postgres | `?` | |
| presto | `81.42% <65.78%> (-0.02%)` | :arrow_down: |
| python | `81.81% <65.78%> (-0.31%)` | :arrow_down: |
| sqlite | `81.18% <65.78%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.07% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `75.00% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `82.94% <ø> (ø)` | |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.27% <0.00%> (-0.64%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `44.53% <11.11%> (ø)` | |
| [superset/utils/profiler.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcHJvZmlsZXIucHk=) | `47.05% <47.05%> (ø)` | |
| [...plore/components/controls/OptionControls/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9PcHRpb25Db250cm9scy9pbmRleC50c3g=) | `90.42% <66.66%> (ø)` | |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.72% <75.00%> (-0.19%)` | :arrow_down: |
| [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `92.68% <85.71%> (-0.66%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...45888ea](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3713b1) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head b3713b1 differs from pull request most recent head 90df140. Consider uploading reports for the commit 90df140 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...90df140](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (919c36d) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42367 +1647
- Misses 12295 12629 +334
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
| mysql | `81.66% <60.41%> (+0.09%)` | :arrow_up: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.12%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...919c36d](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #16150:
URL: https://github.com/apache/superset/pull/16150#discussion_r705456248
##########
File path: superset/tasks/caching/strategies/dashboard_tags.py
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import List, Optional
+
+from sqlalchemy import and_
+
+from superset import db
+from superset.models.dashboard import Dashboard
+from superset.models.slice import Slice
+from superset.models.tags import Tag, TaggedObject
+from superset.tasks.caching.strategies.utils import get_url
+from superset.tasks.caching.strategy import Strategy
+
+
+class DashboardTagsStrategy(Strategy): # pylint: disable=too-few-public-methods
+ """
+ Warm up charts in dashboards with custom tags.
+
+ CELERYBEAT_SCHEDULE = {
+ 'cache-warmup-hourly': {
+ 'task': 'cache-warmup',
+ 'schedule': crontab(minute=1, hour='*'), # @hourly
+ 'kwargs': {
+ 'strategy_name': 'dashboard_tags',
+ 'tags': ['core', 'warmup'],
+ },
+ },
+ }
+ """
+
+ name = "dashboard_tags"
+
+ def __init__(self, tags: Optional[List[str]] = None) -> None:
+ super().__init__()
+ self.tags = tags or []
+
+ def get_urls(self) -> List[str]:
+ urls = []
+ session = db.create_scoped_session()
Review comment:
why? we should be using `with session_scope(nullpool=True) as session`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.22%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head 5588de7. Consider uploading reports for the commit 5588de7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.70% +0.22%
==========================================
Files 997 997
Lines 53245 53240 -5
Branches 6777 6774 -3
==========================================
+ Hits 40720 40838 +118
+ Misses 12295 12172 -123
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <0.00%> (+0.12%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.88% <0.00%> (+0.23%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.40% <0.00%> (+0.25%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...5588de7](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42366 +1646
- Misses 12295 12630 +335
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.48% <60.41%> (-0.08%)` | :arrow_down: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head f58eb1b. Consider uploading reports for the commit f58eb1b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...f58eb1b](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eb5dbb) into [master](https://codecov.io/gh/apache/superset/commit/3709131089ba866de534c0f3765a8e1123df0204?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3709131) will **increase** coverage by `0.26%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head 6eb5dbb differs from pull request most recent head 887fe2a. Consider uploading reports for the commit 887fe2a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.70% 76.96% +0.26%
==========================================
Files 997 996 -1
Lines 53240 53248 +8
Branches 6774 6721 -53
==========================================
+ Hits 40838 40984 +146
+ Misses 12172 12039 -133
+ Partials 230 225 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.23% <ø> (+0.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.14% <100.00%> (+1.83%)` | :arrow_up: |
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `29.26% <0.00%> (-23.80%)` | :arrow_down: |
| [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | `35.44% <0.00%> (-4.10%)` | :arrow_down: |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZENvbGxlY3Rpb24udHN4) | `76.92% <0.00%> (-1.65%)` | :arrow_down: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.69% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | `17.64% <0.00%> (-1.11%)` | :arrow_down: |
| [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `87.30% <0.00%> (-0.94%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.22% <0.00%> (-0.86%)` | :arrow_down: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.27% <0.00%> (-0.64%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3709131...887fe2a](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40e9c76) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 40e9c76 differs from pull request most recent head 45888ea. Consider uploading reports for the commit 45888ea to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 995 995
Lines 52884 52884
Branches 6721 6721
=======================================
Hits 40636 40636
Misses 12023 12023
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.23% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.24% <ø> (ø)` | |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...45888ea](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90df140) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **not change** coverage.
> The diff coverage is `50.00%`.
> :exclamation: Current head 90df140 differs from pull request most recent head c628c44. Consider uploading reports for the commit c628c44 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 997 997
Lines 53245 53245
Branches 6777 6777
=======================================
Hits 40720 40720
Misses 12295 12295
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...c628c44](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (887fe2a) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.46%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 887fe2a differs from pull request most recent head fa5d610. Consider uploading reports for the commit fa5d610 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.24% 76.70% +0.46%
==========================================
Files 997 997
Lines 53205 53240 +35
Branches 6777 6774 -3
==========================================
+ Hits 40566 40838 +272
+ Misses 12409 12172 -237
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.95% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <ø> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <0.00%> (-0.31%)` | :arrow_down: |
| [...perset-frontend/src/addSlice/AddSliceContainer.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLnRzeA==) | `56.66% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.30% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...fa5d610](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.23%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.71% +0.23%
==========================================
Files 997 1002 +5
Lines 53245 55226 +1981
Branches 6777 6777
==========================================
+ Hits 40720 42367 +1647
- Misses 12295 12629 +334
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <ø> (ø)` | |
| mysql | `81.66% <60.41%> (+0.09%)` | :arrow_up: |
| postgres | `81.69% <60.41%> (+0.10%)` | :arrow_up: |
| python | `81.77% <60.41%> (+0.09%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `88.00% <0.00%> (-2.25%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40e9c76) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 40e9c76 differs from pull request most recent head 747677e. Consider uploading reports for the commit 747677e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 995 995
Lines 52884 52884
Branches 6721 6721
=======================================
Hits 40636 40636
Misses 12023 12023
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.23% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.24% <ø> (ø)` | |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...747677e](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8e7f1c) into [master](https://codecov.io/gh/apache/superset/commit/7b724439b97cfe496348be0e1bc2e4b195186e01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b72443) will **increase** coverage by `0.19%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
+ Coverage 76.47% 76.67% +0.19%
==========================================
Files 997 1002 +5
Lines 53245 55190 +1945
Branches 6777 6777
==========================================
+ Hits 40720 42317 +1597
- Misses 12295 12643 +348
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `81.48% <60.41%> (-0.08%)` | :arrow_down: |
| postgres | `?` | |
| python | `81.70% <60.41%> (+0.02%)` | :arrow_up: |
| sqlite | `81.36% <60.41%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/caching/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9jYWNoZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategies/dummy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2R1bW15LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/caching/strategy.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVneS5weQ==) | `83.33% <83.33%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.36% <100.00%> (+0.05%)` | :arrow_up: |
| [...uperset/tasks/caching/strategies/dashboard\_tags.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL2Rhc2hib2FyZF90YWdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/top\_n.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3RvcF9uLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/tasks/caching/strategies/utils.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGluZy9zdHJhdGVnaWVzL3V0aWxzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `84.21% <0.00%> (-3.55%)` | :arrow_down: |
| ... and [43 more](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b72443...a8e7f1c](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-895419791
# [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16150](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45888ea) into [master](https://codecov.io/gh/apache/superset/commit/3bbcc30d69562a7723299d6d673d2b3397c91561?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bbcc30) will **decrease** coverage by `0.22%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16150 +/- ##
==========================================
- Coverage 76.83% 76.61% -0.23%
==========================================
Files 995 995
Lines 52884 52886 +2
Branches 6721 6721
==========================================
- Hits 40636 40521 -115
- Misses 12023 12140 +117
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.54% <33.33%> (-0.05%)` | :arrow_down: |
| postgres | `81.60% <33.33%> (ø)` | |
| presto | `?` | |
| python | `81.69% <33.33%> (-0.43%)` | :arrow_down: |
| sqlite | `81.20% <33.33%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.27% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.47% <0.00%> (-6.49%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.08% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.98% <0.00%> (-0.39%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.61% <0.00%> (-0.26%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/16150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.09% <0.00%> (-0.13%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3bbcc30...45888ea](https://codecov.io/gh/apache/superset/pull/16150?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
mayurnewase edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-1002917271
hi @amitmiran137 I see this was closed without merge.
I have few questions here.
* it calls charts explore url and request lib doesn't load javascript so it doesn’t really gets the data from endpoint which is POST explore_json or POST data which actually loads data into cache.
* also this won't generate thumbnail urls, which would be usefull to warm up as well.
so should we just invoke headless driver like we do for reports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase edited a comment on pull request #16150: feat: EXTRA_CACHING_STRATEGIES
Posted by GitBox <gi...@apache.org>.
mayurnewase edited a comment on pull request #16150:
URL: https://github.com/apache/superset/pull/16150#issuecomment-1002917271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org