You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2014/03/05 00:52:07 UTC
svn commit: r1574257 - in /hive/trunk/ql/src:
java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
test/queries/clientnegative/analyze_non_existent_tbl.q
test/results/clientnegative/analyze_non_existent_tbl.q.out
Author: hashutosh
Date: Tue Mar 4 23:52:07 2014
New Revision: 1574257
URL: http://svn.apache.org/r1574257
Log:
HIVE-6545 : analyze table throws NPE for non-existent tables. (Ashutosh Chauhan via Harish Butani)
Added:
hive/trunk/ql/src/test/queries/clientnegative/analyze_non_existent_tbl.q
hive/trunk/ql/src/test/results/clientnegative/analyze_non_existent_tbl.q.out
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java?rev=1574257&r1=1574256&r2=1574257&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Tue Mar 4 23:52:07 2014
@@ -1236,8 +1236,13 @@ public class SemanticAnalyzer extends Ba
sqAliasToCTEName.put(alias, cte_name);
continue;
}
- throw new SemanticException(ErrorMsg.INVALID_TABLE.getMsg(qb
- .getParseInfo().getSrcForAlias(alias)));
+ ASTNode src = qb.getParseInfo().getSrcForAlias(alias);
+ if (null != src) {
+ throw new SemanticException(ErrorMsg.INVALID_TABLE.getMsg(src));
+ } else {
+ throw new SemanticException(ErrorMsg.INVALID_TABLE.getMsg(alias));
+ }
+
}
// Disallow INSERT INTO on bucketized tables
Added: hive/trunk/ql/src/test/queries/clientnegative/analyze_non_existent_tbl.q
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientnegative/analyze_non_existent_tbl.q?rev=1574257&view=auto
==============================================================================
--- hive/trunk/ql/src/test/queries/clientnegative/analyze_non_existent_tbl.q (added)
+++ hive/trunk/ql/src/test/queries/clientnegative/analyze_non_existent_tbl.q Tue Mar 4 23:52:07 2014
@@ -0,0 +1 @@
+analyze table nonexistent compute statistics;
Added: hive/trunk/ql/src/test/results/clientnegative/analyze_non_existent_tbl.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientnegative/analyze_non_existent_tbl.q.out?rev=1574257&view=auto
==============================================================================
--- hive/trunk/ql/src/test/results/clientnegative/analyze_non_existent_tbl.q.out (added)
+++ hive/trunk/ql/src/test/results/clientnegative/analyze_non_existent_tbl.q.out Tue Mar 4 23:52:07 2014
@@ -0,0 +1 @@
+FAILED: SemanticException [Error 10001]: Table not found nonexistent