You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2008/05/05 22:32:16 UTC

svn commit: r653586 - in /maven/artifact/branches/MNG-3010/src: main/java/org/apache/maven/artifact/versioning/ComparableVersion.java test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java

Author: hboutemy
Date: Mon May  5 13:32:15 2008
New Revision: 653586

URL: http://svn.apache.org/viewvc?rev=653586&view=rev
Log:
fixed reuse of an instance

Modified:
    maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
    maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java

Modified: maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
URL: http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java?rev=653586&r1=653585&r2=653586&view=diff
==============================================================================
--- maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java (original)
+++ maven/artifact/branches/MNG-3010/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java Mon May  5 13:32:15 2008
@@ -40,9 +40,9 @@
 {
     private String value;
 
-    private String canonical = "";
+    private String canonical;
 
-    private ListItem items = new ListItem();
+    private ListItem items;
 
     private interface Item
     {
@@ -300,6 +300,8 @@
     {
         this.value = version;
 
+        items = new ListItem();
+
         version = version.toLowerCase( Locale.ENGLISH );
 
         ListItem list = items;

Modified: maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
URL: http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java?rev=653586&r1=653585&r2=653586&view=diff
==============================================================================
--- maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java (original)
+++ maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java Mon May  5 13:32:15 2008
@@ -167,4 +167,13 @@
         }
     }
 
+    public void testReuse()
+    {
+        ComparableVersion c1 = new ComparableVersion( "1" );
+        c1.parseVersion( "2" );
+
+        Comparable c2 = newComparable( "2" );
+
+        assertEquals( "reused instance should be equivalent to new instance", c1, c2 );
+    }
 }