[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #672: [#671] Metrics of the number of apps submitted by users

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #672:
URL: https://github.com/apache/incubator-uniffle/pull/672#discussion_r1121926956


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/metric/CoordinatorMetrics.java:
##########
@@ -96,6 +98,20 @@ public static void updateDynamicGaugeForRemoteStorage(String storageHost, double
     }
   }
 
+  public static void addDynamicGaugeForUser(String user) {
+    GAUGE_APP_NUM_TO_USER.computeIfAbsent(
+        user, x -> metricsManager.addGauge(APP_NUM_TO_USER + user)).inc();

Review Comment:
   how about add label for this gauge? such as app_num{user_id=xxx} 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org