You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "tteofili (via GitHub)" <gi...@apache.org> on 2024/05/14 13:23:35 UTC
[PR] Add per-field knn vector format info in SegmentInfo [lucene]
tteofili opened a new pull request, #13367:
URL: https://github.com/apache/lucene/pull/13367
When indexing vectors, it is possible to use different vector formats depending on the field; in addition to that it's also possible (although not currently implemented) to have `Codecs` that can provide different vector formats "dynamically" even for a same field.
To better _debug_ such situations, it would be helpful to have per field vector format information within `SegmentCommitInfo` (e.g. within the `attribtues`).
This trivial PR adds `KnnVectorFormat#name` for each field to `SegmentInfo#attributes` in `PerFieldKnnVectorsFormat`.
If a doc with `field1` is indexed with `Lucene99HnswVectorsFormat` and a doc with `field2` is indexed with `Lucene99HnswScalarQuantizedVectorsFormat`, `SegmentInfo#attributes` will have the following entries:
* "KnnVectorFormat.field1" -> "Lucene99HnswVectorsFormat"
* "KnnVectorFormat.field2" -> "Lucene99HnswScalarQuantizedVectorsFormat"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]
Posted by "tteofili (via GitHub)" <gi...@apache.org>.
tteofili commented on PR #13367:
URL: https://github.com/apache/lucene/pull/13367#issuecomment-2110564180
you're right @jpountz , we can probably get away with `fieldInfo.getAttribute(PerFieldKnnVectorFormat.PER_FIELD_FORMAT_KEY)`, I didn't notice that, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]
Posted by "tteofili (via GitHub)" <gi...@apache.org>.
tteofili closed pull request #13367: Add per-field knn vector format info in SegmentInfo
URL: https://github.com/apache/lucene/pull/13367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #13367:
URL: https://github.com/apache/lucene/pull/13367#issuecomment-2110416918
I'm a bit confused: what is the benefit of having it on segment infos in addition to field infos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org