You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/08 15:36:54 UTC

[GitHub] [hudi] guanziyue opened a new pull request, #5530: [HUDI-4055]refactor ratelimiter to avoid stack overflow

guanziyue opened a new pull request, #5530:
URL: https://github.com/apache/hudi/pull/5530

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   RateLimiter recursively call itself to do rate control. In some occasion, it may lead stackOverFlow.
   https://issues.apache.org/jira/browse/HUDI-4055
   
   ## Brief change log
   
   Use loop replace recursive call in rate limiter to avoid stackOverFlow in some special case
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as TestRatelimiter.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5530: [HUDI-4055]refactor ratelimiter to avoid stack overflow

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5530:
URL: https://github.com/apache/hudi/pull/5530#issuecomment-1120441091

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * becdeba10cc43fc7a136e5a3007dad079d23b367 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5530: [HUDI-4055]refactor ratelimiter to avoid stack overflow

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5530:
URL: https://github.com/apache/hudi/pull/5530#issuecomment-1120441723

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8498",
       "triggerID" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * becdeba10cc43fc7a136e5a3007dad079d23b367 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8498) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #5530: [HUDI-4055]refactor ratelimiter to avoid stack overflow

Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5530:
URL: https://github.com/apache/hudi/pull/5530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5530: [HUDI-4055]refactor ratelimiter to avoid stack overflow

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5530:
URL: https://github.com/apache/hudi/pull/5530#issuecomment-1120452852

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8498",
       "triggerID" : "becdeba10cc43fc7a136e5a3007dad079d23b367",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * becdeba10cc43fc7a136e5a3007dad079d23b367 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8498) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org