You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/02/08 19:48:52 UTC

[GitHub] [airflow] pankajastro commented on a diff in pull request #28618: Add deferrable mode to DataprocInstantiateWorkflowTemplateOperator

pankajastro commented on code in PR #28618:
URL: https://github.com/apache/airflow/pull/28618#discussion_r1100604698


##########
airflow/providers/google/cloud/triggers/dataproc.py:
##########
@@ -84,3 +84,73 @@ async def run(self):
                     raise AirflowException(f"Dataproc job execution failed {self.job_id}")
             await asyncio.sleep(self.polling_interval_seconds)
         yield TriggerEvent({"job_id": self.job_id, "job_state": state})
+
+
+class DataprocWorkflowTrigger(BaseTrigger):

Review Comment:
   @VladaZakharova  @bkossakowska somehow I thought this PR has merged so I created https://github.com/apache/airflow/pull/29364 PR to do some refactoring on the trigger and address my above comments.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org