You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:38:15 UTC
[GitHub] [inlong] healchow commented on a diff in pull request #5525: [INLONG-5352][Sort] Add audit report for Pulsar source
healchow commented on code in PR #5525:
URL: https://github.com/apache/inlong/pull/5525#discussion_r944336873
##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/DynamicPulsarDeserializationSchema.java:
##########
@@ -103,16 +115,21 @@ public void open(DeserializationSchema.InitializationContext context) throws Exc
if (inlongMetric != null && !inlongMetric.isEmpty()) {
String[] inLongMetricArray = inlongMetric.split(DELIMITER);
Review Comment:
Suggested changing to `inlongMetricArray`.
##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/PulsarDynamicTableSource.java:
##########
@@ -162,7 +164,8 @@ public PulsarDynamicTableSource(
Properties properties,
PulsarTableOptions.StartupOptions startupOptions,
boolean upsertMode,
- String inlongMetric) {
+ String inlongMetric,
+ String auditHostAndPorts) {
Review Comment:
The indent lost 4 blanks.
##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/DynamicPulsarDeserializationSchema.java:
##########
@@ -63,6 +67,13 @@ public SimpleCollector initialValue() {
private final boolean upsertMode;
private SourceMetricData sourceMetricData;
private String inlongMetric;
+ private String auditHostAndPorts;
+
+ private AuditImp auditImp;
+
+ private String inLongGroupId;
+
+ private String inLongStreamId;
Review Comment:
Suggested changing to `inlongGroupId` and `inlongStreamId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org