[drill] branch master updated: DRILL-7202: Failed query shows warning that fragments made no progress

[so...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sorabh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git


The following commit(s) were added to refs/heads/master by this push:
     new c36bb7a  DRILL-7202: Failed query shows warning that fragments made no progress
c36bb7a is described below

commit c36bb7a517fc965d5331e8da17b43a19cbfc2309
Author: Kunal Khatua <kk...@maprtech.com>
AuthorDate: Wed Apr 24 15:04:26 2019 -0700

    DRILL-7202: Failed query shows warning that fragments made no progress
    
    This bug arises because of the `toggleWarning()` javascript function that shows the warning if the number of slow major fragments matches the number of major fragments.
    For failed queries, the number of major fragments = 0; and that matches the number of tags (which is also zero for a non-running query). Hence the warning shows.
---
 exec/java-exec/src/main/resources/rest/profile/profile.ftl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/exec/java-exec/src/main/resources/rest/profile/profile.ftl b/exec/java-exec/src/main/resources/rest/profile/profile.ftl
index 8445a40..97f03e9 100644
--- a/exec/java-exec/src/main/resources/rest/profile/profile.ftl
+++ b/exec/java-exec/src/main/resources/rest/profile/profile.ftl
@@ -57,7 +57,9 @@
       //No Progress Warning
       let noProgressFragmentCount = document.querySelectorAll('td[class=no-progress-tag]').length;
       let majorFragmentCount = document.querySelectorAll('#fragment-overview table tbody tr').length;
-      toggleWarning("noProgressWarning", majorFragmentCount, noProgressFragmentCount);
+      if (majorFragmentCount > 0) { // For fast-failed queries majorFragmentCount=0
+        toggleWarning("noProgressWarning", majorFragmentCount, noProgressFragmentCount);
+      }
 
       //Spill To Disk Warnings
       let spillCount = document.querySelectorAll('td[class=spill-tag]').length;