You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/17 05:49:37 UTC
[GitHub] [incubator-doris] Gabriel39 commented on a change in pull request #7067: [Feature] Add a scheduling strategy for high-throughput point query scenarios.
Gabriel39 commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r750899047
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1359,7 +1360,13 @@ private void computeScanRangeAssignment() throws Exception {
bucketShuffleJoinController.computeScanRangeAssignmentByBucket((OlapScanNode) scanNode, idToBackend, addressToBackendID);
}
if (!(fragmentContainsColocateJoin | fragmentContainsBucketShuffleJoin)) {
- computeScanRangeAssignmentByScheduler(scanNode, locations, assignment, assignedBytesPerHost);
+ long schedulingStrategy = (ConnectContext.get() == null ? ExecSchedulingStrategy.EVENLY_BACKEND.getValue() :
+ ConnectContext.get().getSessionVariable().getExecSchedulingStrategy());
+ if (schedulingStrategy == ExecSchedulingStrategy.MIN_BACKEND.getValue()) {
+ computeScanRangeAssignmentWithMinNodeStrategy(scanNode, locations, assignment, assignedBytesPerHost);
Review comment:
could you supplement UT for this new strategy?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -154,17 +154,19 @@
public static final long DEFAULT_INSERT_VISIBLE_TIMEOUT_MS = 10_000;
public static final String EXTRACT_WIDE_RANGE_EXPR = "extract_wide_range_expr";
-
Review comment:
unnecessary update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org