You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/13 00:53:07 UTC

[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on pull request #2016:
URL: https://github.com/apache/calcite/pull/2016#issuecomment-643544569


   > I have to say that I don't see how this pull request makes hash code more efficient (precomputation of hashcode?). For sure it looks to increase memory usage and also remove lots of flexibility for Calcite users extending on RelNode and RexnNode...
   
   Compare to the old code, this patch reduce the memory usage, especially for the `RexNode`. What do you mean by remove lots of flexibility for Calcite users ? Which flexibility do i remove ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org