You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/06/10 09:56:55 UTC
Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1182
https://issues.apache.org/jira/browse/LENS-1182
Repository: lens
Description
-------
Diffs
-----
lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
Diff: https://reviews.apache.org/r/48539/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 14, 2016, 11:16 p.m., Ankeet Maini wrote:
> > lens-ui/app/components/DatabaseComponent.js, line 130
> > <https://reviews.apache.org/r/48539/diff/1-2/?file=1414543#file1414543line130>
> >
> > event will never be `string`, so we can remove this check.
> >
> > if (event) {
> > // code here
> > }
> >
> > above can be used.
this is called from the constructor in case url is like `/schema/dbname/...`. There it's passed as string.
> On June 14, 2016, 11:16 p.m., Ankeet Maini wrote:
> > lens-ui/app/components/CubeSchemaComponent.js, line 56
> > <https://reviews.apache.org/r/48539/diff/2/?file=1416813#file1416813line56>
> >
> > Again, when will this be of type `string`? Also please use `===`
So cubes are of two types: `x_base_cube` and `x_derived_cube`. In case of base cube, measures and dimensions are objects, but in case of derived cube, they are just names. A derived cube has a parent cube and the parent has to be a base cube. The measure names should all be properly defined in the parent cube for the derived cube to be valid, and similarly the dim attribute names in the derived cube all have to be names of valid dim attributes present in the parent cube.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review137551
-----------------------------------------------------------
On June 13, 2016, 6:29 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 6:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review137551
-----------------------------------------------------------
lens-ui/app/components/DatabaseComponent.js (line 129)
<https://reviews.apache.org/r/48539/#comment202697>
event will never be `string`, so we can remove this check.
if (event) {
// code here
}
above can be used.
lens-ui/app/components/CubeSchemaComponent.js (line 56)
<https://reviews.apache.org/r/48539/#comment202696>
Again, when will this be of type `string`? Also please use `===`
- Ankeet Maini
On June 13, 2016, 12:59 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 12:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review138158
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 13, 2016, 12:59 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 12:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review137680
-----------------------------------------------------------
Ship it!
Ship It!
- Ankeet Maini
On June 13, 2016, 12:59 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 12:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 14, 2016, 10:59 p.m., Ankeet Maini wrote:
> > lens-ui/app/components/CubeSchemaComponent.js, line 33
> > <https://reviews.apache.org/r/48539/diff/2/?file=1416813#file1416813line33>
> >
> > `measure` will always be an object, or it can be a `string` also?
It can be string too. Check the changes in `receiveCube` in CubeStore.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review137550
-----------------------------------------------------------
On June 13, 2016, 6:29 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 6:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Ankeet Maini <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/#review137550
-----------------------------------------------------------
lens-ui/app/components/CubeSchemaComponent.js (line 33)
<https://reviews.apache.org/r/48539/#comment202694>
`measure` will always be an object, or it can be a `string` also?
- Ankeet Maini
On June 13, 2016, 12:59 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48539/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 12:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1182
> https://issues.apache.org/jira/browse/LENS-1182
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
> lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
> lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
> lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
> lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
> lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
> lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
> lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
> lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
> lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
> lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
> lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
> lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
> lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
>
> Diff: https://reviews.apache.org/r/48539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48539: LENS-1182: Lens UI Should set database and
refresh cubes pane on db switch
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48539/
-----------------------------------------------------------
(Updated June 13, 2016, 6:29 p.m.)
Review request for lens.
Bugs: LENS-1182
https://issues.apache.org/jira/browse/LENS-1182
Repository: lens
Description
-------
Diffs (updated)
-----
lens-ui/app/actions/AdhocQueryActions.js 2a4b47b586ce2456b9a2a4abbe4438508d1eac7d
lens-ui/app/adapters/AdhocQueryAdapter.js 445d6f2a99baf52e8e24343055d5d108e9f224ab
lens-ui/app/app.js 73cb511f488bfbfd4a079f5a8c5ebade1d7925bb
lens-ui/app/components/AdhocQueryComponent.js 32fab33e36180986708ca4b25dc04fb875ab1aae
lens-ui/app/components/CubeSchemaComponent.js f56d9c2d7c42aadfccd5799fff9eb3e08156a674
lens-ui/app/components/CubeTreeComponent.js e2884767db0118f92063c55b6581a057b344a9ec
lens-ui/app/components/DatabaseComponent.js 09c9e7b21eceb5c032069d2d00d762ab0097557b
lens-ui/app/components/QueryBoxComponent.js ec6a06b1551c72a307a1e0fc4a71e29a339af001
lens-ui/app/components/SidebarComponent.js 37a2c59b158d456a67fb39ed6024b0d6ae5c24dc
lens-ui/app/components/TableTreeComponent.js 2e623997954761b87eee037c928252271acc01e4
lens-ui/app/constants/AdhocQueryConstants.js ea8cbd0e039ddd3eb980a5db54708cc76a9585ca
lens-ui/app/stores/CubeStore.js d4825a97e754bbd5d9d32e374943471690a5629d
lens-ui/app/stores/DatabaseStore.js b13246efe8e5ccfc525d8843ee69e757d73ddc04
lens-ui/server.js 736d86262ba3dfb44c5ef7b1fa26edadbaeeaab7
Diff: https://reviews.apache.org/r/48539/diff/
Testing
-------
Thanks,
Rajat Khandelwal