You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (via GitHub)" <gi...@apache.org> on 2023/11/03 03:48:52 UTC
[I] Reverse package dependency found: `triple` is replying on `server` [dubbo-go]
chickenlj opened a new issue, #2482:
URL: https://github.com/apache/dubbo-go/issues/2482
```
刘军:imports dubbo.apache.org/dubbo-go/v3/protocol/triple
imports dubbo.apache.org/dubbo-go/v3/server
刘军:@王宇轩 这个triple依赖server的依赖关系合理吗?
刘军:是不是应该server不被其他package依赖
王宇轩:@刘军 是的,应该是server依赖下层
王宇轩:triple应该提供自己的info struct,client info和server info属于更高层次的info,用它们转化成协议各自需要的info
刘军:我今天做一些调整时发现有这个反向依赖问题,这块好改吗?serverinfo挪个位置能不能解决
王宇轩:我觉得最好是triple定义自己需要的info,server层或者invoker链上的protocol_filter_wrapper根据具体协议将serverInfo进行转化
王宇轩:那么triple就能做到完全不感知上层,我们把triple所有可能的输入通过test进行覆盖,由这些用例来确定triple的边界。我觉得这应该是我们的一个目标,让其它那些需要通过config.Load启动的用例都变成这种形式
刘军:@王宇轩 听起来没问题[赞]。咱们这个版本的目标那,先保持不动吧,这个记一个issue,下一个版本来迭代
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] Reverse package dependency found: `triple` is replying on `server` [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on issue #2482:
URL: https://github.com/apache/dubbo-go/issues/2482#issuecomment-2571741678
This issue has been resolved in #2760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] Reverse package dependency found: `triple` is replying on `server` [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn closed issue #2482: Reverse package dependency found: `triple` is replying on `server`
URL: https://github.com/apache/dubbo-go/issues/2482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org