You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 12:04:47 UTC
[GitHub] [airflow] sunank200 opened a new pull request #20712: Fix MyPy issues in providers imap
sunank200 opened a new pull request #20712:
URL: https://github.com/apache/airflow/pull/20712
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunank200 closed pull request #20712: Fix MyPy issues in providers imap
Posted by GitBox <gi...@apache.org>.
sunank200 closed pull request #20712:
URL: https://github.com/apache/airflow/pull/20712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #20712: Fix MyPy issues in providers imap
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #20712:
URL: https://github.com/apache/airflow/pull/20712#issuecomment-1006535251
Closing this since it is already merged in https://github.com/apache/airflow/commit/4fa9cfd7de13cd79956fbb68f8416a5a019465a4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20712: Fix MyPy issues in providers imap
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20712:
URL: https://github.com/apache/airflow/pull/20712#discussion_r779501008
##########
File path: airflow/providers/imap/hooks/imap.py
##########
@@ -71,7 +71,11 @@ def get_conn(self) -> 'ImapHook':
"""
if not self.mail_client:
conn = self.get_connection(self.imap_conn_id)
- self.mail_client = imaplib.IMAP4_SSL(conn.host, conn.port or imaplib.IMAP4_SSL_PORT)
+ self.mail_client = imaplib.IMAP4_SSL(
+ conn.host, conn.port or imaplib.IMAP4_SSL_PORT # type:ignore
+ )
+ # imaplib.IMAP4_SSL() aspects port in the argument and port here is conn.port or
Review comment:
```suggestion
# imaplib.IMAP4_SSL() expects port in the argument and port here is conn.port or
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org